Add NGColumnLayoutAlgorithm skeleton implementation.

Add NGColumnLayoutAlgorithm skeleton implementation.

This patch adds the placeholder for NGColumnLayoutAlgorithm class
and refactors NG(Inline|Block|Column)LayoutAlgorithm classes
moving some common logic to NGLayoutAlgorithm base class.

BUG=635619
Review-Url: https://codereview.chromium.org/2782603003
Cr-Commit-Position: refs/heads/master@{#460513}
Committed: https://chromium.googlesource.com/chromium/src/+/9996a777ad04b37b24711e97894ff1e4e35bcede

[Gleb Lanbin, 2017-03-28 23:47:55]

glebl@chromium.org changed reviewers:
+ cbiesinger@chromium.org, kojii@chromium.org

[cbiesinger, 2017-03-29 14:50:11]

lgtm. cc mstensho, fyi

[Gleb Lanbin, 2017-03-29 16:25:56]

Description was changed from

==========
Add NGColumnLayoutAlgorithm skeleton implementation.

This patch adds the placeholder for NGLayoutAlgorithm class and
refactors NG(Inline|Block|Column)LayoutAlgorithm classes moving some
common logic to NGLayoutAlgorithm base class.

BUG=635619
==========

to

==========
Add NGColumnLayoutAlgorithm skeleton implementation.

This patch adds the placeholder for NGColumnLayoutAlgorithm class
and refactors NG(Inline|Block|Column)LayoutAlgorithm classes
moving some common logic to NGLayoutAlgorithm base class.

BUG=635619
==========

[Gleb Lanbin, 2017-03-29 16:26:23]

glebl@chromium.org changed reviewers:
+ mstensho@opera.com

[Gleb Lanbin, 2017-03-29 16:28:16]

On 2017/03/29 14:50:11, cbiesinger wrote:
> lgtm. cc mstensho, fyi

Thanks, Christian. I forgot to add Morten. Morten, your feedback is more than
welcome.

[Gleb Lanbin, 2017-03-29 16:28:23]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 16:29:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mstensho (USE GERRIT), 2017-03-29 17:28:46]

Skimmed through it earlier today anyway. :)

lgtm.

Next step is to incorporate
https://codereview.chromium.org/2693193002/patch/80001/90003 & co, or?

[Gleb Lanbin, 2017-03-29 17:48:05]

On 2017/03/29 17:28:46, mstensho wrote:
> Skimmed through it earlier today anyway. :)
> 
> lgtm.
> 
> Next step is to incorporate
> https://codereview.chromium.org/2693193002/patch/80001/90003 & co, or?

Actually I was under impression that http://crrev.com/2693193002 is already
submitted. I want to experiment a bit with copying NG multi column fragments
information back to the legacy tree.
This patch is more about moving the common logic to NGLayoutAlgorithm.

[commit-bot: I haz the power, 2017-03-29 17:52:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 17:52:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Gleb Lanbin, 2017-03-29 18:07:40]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 18:08:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 20:04:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 20:04:26]

Dry run: This issue passed the CQ dry run.

[Gleb Lanbin, 2017-03-29 20:07:13]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2017-03-29 20:07:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org, mstensho@opera.com
Link to the patchset: https://codereview.chromium.org/2782603003/#ps20001
(title: "update TestExpectations")

[commit-bot: I haz the power, 2017-03-29 20:08:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 20:16:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490818033932250,
"parent_rev": "7a9ca6839f01ad26a41816f4d91a404a0ad49a62", "commit_rev":
"9996a777ad04b37b24711e97894ff1e4e35bcede"}

[commit-bot: I haz the power, 2017-03-29 20:16:50]

Description was changed from

==========
Add NGColumnLayoutAlgorithm skeleton implementation.

This patch adds the placeholder for NGColumnLayoutAlgorithm class
and refactors NG(Inline|Block|Column)LayoutAlgorithm classes
moving some common logic to NGLayoutAlgorithm base class.

BUG=635619
==========

to

==========
Add NGColumnLayoutAlgorithm skeleton implementation.

This patch adds the placeholder for NGColumnLayoutAlgorithm class
and refactors NG(Inline|Block|Column)LayoutAlgorithm classes
moving some common logic to NGLayoutAlgorithm base class.

BUG=635619

Review-Url: https://codereview.chromium.org/2782603003
Cr-Commit-Position: refs/heads/master@{#460513}
Committed:
https://chromium.googlesource.com/chromium/src/+/9996a777ad04b37b24711e97894f...
==========

[commit-bot: I haz the power, 2017-03-29 20:16:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9996a777ad04b37b24711e97894f...

[Gleb Lanbin, 2017-03-30 22:24:28]

Patchset #3 (id:40001) has been deleted