Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: components/translate/core/browser/translate_prefs_unittest.cc

Issue 2782553004: Move TestingPrefService to use unique_ptr<Value> (Closed)
Patch Set: comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_prefs_unittest.cc
diff --git a/components/translate/core/browser/translate_prefs_unittest.cc b/components/translate/core/browser/translate_prefs_unittest.cc
index 8ef04f99ec93bcaf71cd16bd51d41e643e4f6ef5..5fa78fdc30b23f63432566d4f7f381f0ffc988f6 100644
--- a/components/translate/core/browser/translate_prefs_unittest.cc
+++ b/components/translate/core/browser/translate_prefs_unittest.cc
@@ -240,7 +240,7 @@ TEST_F(TranslatePrefTest, ULPPrefs) {
<< error_column << std::endl
<< json1;
- prefs_->SetUserPref(TranslatePrefs::kPrefLanguageProfile, profile.release());
+ prefs_->SetUserPref(TranslatePrefs::kPrefLanguageProfile, std::move(profile));
TranslatePrefs::LanguageAndProbabilityList list;
EXPECT_EQ(0.8, translate_prefs_->GetReadingFromUserLanguageProfile(&list));
@@ -288,7 +288,7 @@ TEST_F(TranslatePrefTest, ULPPrefs) {
<< error_column << std::endl
<< json2;
- prefs_->SetUserPref(TranslatePrefs::kPrefLanguageProfile, profile.release());
+ prefs_->SetUserPref(TranslatePrefs::kPrefLanguageProfile, std::move(profile));
list.clear();
EXPECT_EQ(0.3, translate_prefs_->GetReadingFromUserLanguageProfile(&list));
@@ -325,7 +325,7 @@ TEST_F(TranslatePrefTest, ULPPrefs) {
<< error_column << std::endl
<< json3;
- prefs_->SetUserPref(TranslatePrefs::kPrefLanguageProfile, profile.release());
+ prefs_->SetUserPref(TranslatePrefs::kPrefLanguageProfile, std::move(profile));
list.clear();
EXPECT_EQ(0.8, translate_prefs_->GetReadingFromUserLanguageProfile(&list));

Powered by Google App Engine
This is Rietveld 408576698