Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: chrome/browser/chromeos/arc/arc_session_manager_unittest.cc

Issue 2782553004: Move TestingPrefService to use unique_ptr<Value> (Closed)
Patch Set: comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
diff --git a/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc b/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
index 9ab638d2922624d785c487ae967d14855e51acc5..e8d5de7755c7cb76a6ce334a6cd510e44736225f 100644
--- a/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
+++ b/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
@@ -500,7 +500,8 @@ TEST_P(ArcSessionManagerPolicyTest, SkippingTerms) {
// Enable ARC through user pref or by policy, according to the test parameter.
if (arc_enabled_pref_managed())
- prefs->SetManagedPref(prefs::kArcEnabled, new base::Value(true));
+ prefs->SetManagedPref(prefs::kArcEnabled,
+ base::MakeUnique<base::Value>(true));
else
prefs->SetBoolean(prefs::kArcEnabled, true);
EXPECT_TRUE(IsArcPlayStoreEnabledForProfile(profile()));
@@ -508,11 +509,11 @@ TEST_P(ArcSessionManagerPolicyTest, SkippingTerms) {
// Assign test values to the prefs.
if (backup_restore_pref_value().is_bool()) {
prefs->SetManagedPref(prefs::kArcBackupRestoreEnabled,
- backup_restore_pref_value().DeepCopy());
+ backup_restore_pref_value().CreateDeepCopy());
}
if (location_service_pref_value().is_bool()) {
prefs->SetManagedPref(prefs::kArcLocationServiceEnabled,
- location_service_pref_value().DeepCopy());
+ location_service_pref_value().CreateDeepCopy());
}
arc_session_manager()->SetProfile(profile());
@@ -560,7 +561,8 @@ TEST_P(ArcSessionManagerPolicyTest, ReenableManagedArc) {
profile()->GetTestingPrefService();
// Set ARC to be managed.
- prefs->SetManagedPref(prefs::kArcEnabled, new base::Value(true));
+ prefs->SetManagedPref(prefs::kArcEnabled,
+ base::MakeUnique<base::Value>(true));
EXPECT_TRUE(arc::IsArcPlayStoreEnabledForProfile(profile()));
arc_session_manager()->SetProfile(profile());
@@ -692,8 +694,8 @@ class ArcSessionOobeOptInNegotiatorTest
profile());
connector->OverrideIsManagedForTesting(true);
- profile()->GetTestingPrefService()->SetManagedPref(prefs::kArcEnabled,
- new base::Value(true));
+ profile()->GetTestingPrefService()->SetManagedPref(
+ prefs::kArcEnabled, base::MakeUnique<base::Value>(true));
}
arc_session_manager()->SetProfile(profile());

Powered by Google App Engine
This is Rietveld 408576698