Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: chrome/browser/bookmarks/managed_bookmark_service_unittest.cc

Issue 2782553004: Move TestingPrefService to use unique_ptr<Value> (Closed)
Patch Set: comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/managed_bookmark_service_unittest.cc
diff --git a/chrome/browser/bookmarks/managed_bookmark_service_unittest.cc b/chrome/browser/bookmarks/managed_bookmark_service_unittest.cc
index 9d60c1710d5d6437da8b47b08f21ceb432bb5e08..8bb4e49ab2a26f87a5080ef410aa74b70d7e700f 100644
--- a/chrome/browser/bookmarks/managed_bookmark_service_unittest.cc
+++ b/chrome/browser/bookmarks/managed_bookmark_service_unittest.cc
@@ -45,7 +45,7 @@ class ManagedBookmarkServiceTest : public testing::Test {
// TODO(crbug.com/697817): Convert SetManagedPrefs to take a unique_ptr.
prefs_->SetManagedPref(bookmarks::prefs::kManagedBookmarks,
- CreateTestTree().release());
+ CreateTestTree());
ResetModel();
// The managed node always exists.
@@ -178,7 +178,7 @@ TEST_F(ManagedBookmarkServiceTest, SwapNodes) {
const BookmarkNode* parent = managed_->managed_node();
EXPECT_CALL(observer_, BookmarkNodeMoved(model_, parent, 1, parent, 0));
prefs_->SetManagedPref(bookmarks::prefs::kManagedBookmarks,
- updated->DeepCopy());
+ updated->CreateDeepCopy());
Mock::VerifyAndClearExpectations(&observer_);
// Verify the final tree.
@@ -195,7 +195,7 @@ TEST_F(ManagedBookmarkServiceTest, RemoveNode) {
const BookmarkNode* parent = managed_->managed_node();
EXPECT_CALL(observer_, BookmarkNodeRemoved(model_, parent, 1, _, _));
prefs_->SetManagedPref(bookmarks::prefs::kManagedBookmarks,
- updated->DeepCopy());
+ updated->CreateDeepCopy());
Mock::VerifyAndClearExpectations(&observer_);
// Verify the final tree.
@@ -215,7 +215,7 @@ TEST_F(ManagedBookmarkServiceTest, CreateNewNodes) {
const BookmarkNode* parent = managed_->managed_node();
EXPECT_CALL(observer_, BookmarkNodeRemoved(model_, parent, 1, _, _)).Times(2);
prefs_->SetManagedPref(bookmarks::prefs::kManagedBookmarks,
- updated->DeepCopy());
+ updated->CreateDeepCopy());
Mock::VerifyAndClearExpectations(&observer_);
// Verify the final tree.

Powered by Google App Engine
This is Rietveld 408576698