Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2782553003: Remove unused header editor.h (Closed)

Created:
3 years, 8 months ago by bhagirathi.s
Modified:
3 years, 8 months ago
Reviewers:
tkent, Srirama, yosin_UTC9
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused header editor.h Editor.h is included in FocusController.cpp and SpellCheckerClientImpl.cpp but not used. Removed it to reduce unnecessary dependency from editor class. BUG=693887 Review-Url: https://codereview.chromium.org/2782553003 Cr-Commit-Position: refs/heads/master@{#461061} Committed: https://chromium.googlesource.com/chromium/src/+/a88e0c666a6779d12c8af4a32f02f468bf6904b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/core/page/FocusController.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
bhagirathi.s
PTAL
3 years, 8 months ago (2017-03-28 12:43:44 UTC) #4
Srirama
Peer review looks fine.
3 years, 8 months ago (2017-03-28 12:44:58 UTC) #6
yosin_UTC9
lgtm Good catch! Thanks for working this. +tkent@ for OWNERS review.
3 years, 8 months ago (2017-03-29 02:00:52 UTC) #8
tkent
lgtm
3 years, 8 months ago (2017-03-29 02:24:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782553003/1
3 years, 8 months ago (2017-03-29 02:24:55 UTC) #11
commit-bot: I haz the power
The author bhagirathi.s@samsung.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
3 years, 8 months ago (2017-03-29 02:24:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782553003/1
3 years, 8 months ago (2017-03-31 04:25:03 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 06:53:26 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a88e0c666a6779d12c8af4a32f02...

Powered by Google App Engine
This is Rietveld 408576698