Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2782513002: DevTools: perfectly center shevron icon (Closed)

Created:
3 years, 9 months ago by lushnikov
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: perfectly center shevron icon This patch: - centers shevron icon inside its spritesheet (largeIcons.svg) - centers icon inside its container div BUG=705371 R=dgozman Review-Url: https://codereview.chromium.org/2782513002 Cr-Commit-Position: refs/heads/master@{#459999} Committed: https://chromium.googlesource.com/chromium/src/+/ff3b9813827f6a237045257e87ad4f9711caf9e0

Patch Set 1 #

Messages

Total messages: 9 (4 generated)
lushnikov
please, take a look
3 years, 9 months ago (2017-03-27 23:55:54 UTC) #2
dgozman
Are there more problems with other icons? lgtm
3 years, 9 months ago (2017-03-28 01:10:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782513002/1
3 years, 9 months ago (2017-03-28 01:12:54 UTC) #5
lushnikov
i'm not aware of any, but I keep an eye on the bug tracker :)
3 years, 9 months ago (2017-03-28 01:13:03 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-28 03:34:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ff3b9813827f6a237045257e87ad...

Powered by Google App Engine
This is Rietveld 408576698