Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 2782483004: Simplify some shadow crossing logic in SelectorQuery.cpp (Closed)

Created:
3 years, 8 months ago by esprehn
Modified:
3 years, 8 months ago
Reviewers:
meade_UTC10, dglazkov, rune
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify some shadow crossing logic in SelectorQuery.cpp ElementTraversal::firstWithin is the same as doing ::next(rootNode, &rootNode) we can just do that here. We can also use isOpenOrV0() to remove some verbose checks, and finally we don't need to check isShadowHost (which contains a bunch of duplciate checks) and can just null check ::shadow() which is equivalent. BUG=703900 Review-Url: https://codereview.chromium.org/2782483004 Cr-Commit-Position: refs/heads/master@{#460544} Committed: https://chromium.googlesource.com/chromium/src/+/ab0448c6ce0471b98a8a7538a1a07377e41ff0bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M third_party/WebKit/Source/core/dom/SelectorQuery.cpp View 3 chunks +8 lines, -17 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
esprehn
3 years, 8 months ago (2017-03-29 17:47:29 UTC) #10
rune
lgtm
3 years, 8 months ago (2017-03-29 20:59:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782483004/1
3 years, 8 months ago (2017-03-29 21:41:46 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 21:50:06 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ab0448c6ce0471b98a8a7538a1a0...

Powered by Google App Engine
This is Rietveld 408576698