Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2782483002: Disable -Wl,--gdb-index with LTO. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 83d649b4c44ad5724d446fae9df91943c2e4422c..a4def5a766ee829190caf232a95036d13f06d081 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1661,7 +1661,12 @@ config("symbols") {
# obj/native_client/src/trusted/service_runtime/sel_asm/nacl_switch_32.o:
# DWARF info may be corrupt; offsets in a range list entry are in different
# sections" there. Maybe just a bug in nacl_switch_32.S.
- if (!is_mac && !is_ios && !is_nacl && target_cpu != "x86") {
+ # TODO(thakis): Figure out if there's a way to make this go for official
+ # builds, currently get
+ # "third_party/binutils/Linux_x64/Release/bin/ld.gold: warning:
+ # /tmp/lto-llvm-0b5201.o: corrupt debug info in .debug_info"
+ if (!is_mac && !is_ios && !is_nacl && target_cpu != "x86" &&
+ !is_official_build) {
krasin1 2017/03/28 17:03:38 This is not probably what we want here. We need to
ldflags += [ "-Wl,--gdb-index" ]
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698