Issue 2782473002: [ash-md] Restores handler for VPN Disconnect button in system menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2782473002: [ash-md] Restores handler for VPN Disconnect button in system menu (Closed)

Created:
3 years, 9 months ago by varkha

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

[ash-md] Restores handler for VPN Disconnect button in system menu The handler was unintentionally lost in MD work which got exposed after turning the MD to be on by default in M-56. Breaking CL - https://codereview.chromium.org/2463163002 BUG=704299 Review-Url: https://codereview.chromium.org/2768973002 Cr-Commit-Position: refs/heads/master@{#459182} (cherry picked from commit c2637be18c2e52da142d6cbf646ab82045e13218) Review-Url: https://codereview.chromium.org/2782473002 . Cr-Commit-Position: refs/branch-heads/3029@{#439} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/260f32670b26b1669f30ecf8d5009e78f1072d14

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -0 lines)			Patch
	M	ash/common/system/chromeos/network/vpn_list_view.cc	View		3 chunks	+26 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

varkha

3 years, 9 months ago (2017-03-27 20:01:59 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
260f32670b26b1669f30ecf8d5009e78f1072d14.