Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2782443003: Initialize referenceDecodedAudioBuffer correctly. (Closed)

Created:
3 years, 9 months ago by Raymond Toy
Modified:
3 years, 8 months ago
Reviewers:
hongchan
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize referenceDecodedAudioBuffer correctly. During the conversion to testharness, we forgot to initialize referenceDecodedAudioBuffer to the decoded audio file. This causes an error to be signaled as a harness error but allowed the tests to pass still. Also remove from TestExpectations because the test harness error is fixed. BUG=705621, 705125 TEST=decode-audio-data-basic.html Review-Url: https://codereview.chromium.org/2782443003 Cr-Commit-Position: refs/heads/master@{#460148} Committed: https://chromium.googlesource.com/chromium/src/+/fa85c2e913c2293062171ce3ef31c44216c8b444

Patch Set 1 #

Patch Set 2 : Remove decode-audio-data-basic.html from TestExpectations #

Total comments: 2

Patch Set 3 : Remove extra blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/decodeAudioData/decode-audio-data-basic.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Raymond Toy
PTAL
3 years, 9 months ago (2017-03-27 19:05:30 UTC) #2
hongchan
lgtm https://codereview.chromium.org/2782443003/diff/20001/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2782443003/diff/20001/third_party/WebKit/LayoutTests/TestExpectations#newcode1 third_party/WebKit/LayoutTests/TestExpectations:1: Adding one empty line at the beginning?
3 years, 8 months ago (2017-03-28 16:00:51 UTC) #5
Raymond Toy
https://codereview.chromium.org/2782443003/diff/20001/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2782443003/diff/20001/third_party/WebKit/LayoutTests/TestExpectations#newcode1 third_party/WebKit/LayoutTests/TestExpectations:1: On 2017/03/28 16:00:51, hongchan wrote: > Adding one empty ...
3 years, 8 months ago (2017-03-28 16:14:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782443003/40001
3 years, 8 months ago (2017-03-28 16:16:43 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 17:19:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fa85c2e913c2293062171ce3ef31...

Powered by Google App Engine
This is Rietveld 408576698