Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2782403002:
[ES6 modules] Implement #concept-module-script-instantiation-error (Closed)
|
Created:
3 years, 8 months ago by kouhei (in TOK) Modified:
3 years, 8 months ago CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[ES6 modules] Implement #concept-module-script-instantiation-error
This CL implements the spec concept "instantiation error" as ModuleScript::m_instantiationError.
https://html.spec.whatwg.org/multipage/webappapis.html#concept-module-script-instantiation-error
BUG=594639
Review-Url: https://codereview.chromium.org/2782403002
Cr-Commit-Position: refs/heads/master@{#462099}
Committed: https://chromium.googlesource.com/chromium/src/+/6ea86583949ca6e382e3e481243236619359f29c
Patch Set 1 #Patch Set 2 : dep #
Total comments: 2
Patch Set 3 : rebased #
Depends on Patchset: Messages
Total messages: 24 (14 generated)
The CQ bit was checked by kouhei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
kouhei@chromium.org changed reviewers: + hiroshige@chromium.org, yhirano@chromium.org
Not landable yet, but review/lgt appreciated This CL requires https://codereview.chromium.org/2788533002/ and its subsequent CLs to make Modulator/et al TraceWrapperBase
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [ES6 modules] Implement https://html.spec.whatwg.org/multipage/webappapis.html#concept-module-script-... This CL implements the spec concept "instantiation error" as ModuleScript::m_instantiationError. BUG=594639 ========== to ========== [ES6 modules] Implement #concept-module-script-instantiation-error This CL implements the spec concept "instantiation error" as ModuleScript::m_instantiationError. https://html.spec.whatwg.org/multipage/webappapis.html#concept-module-script-... BUG=594639 ==========
kouhei@chromium.org changed reviewers: + domenic@chromium.org, haraken@chromium.org, kinuko@chromium.org
ptal
The CQ bit was checked by kouhei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
https://codereview.chromium.org/2782403002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/dom/ModuleScript.h (right): https://codereview.chromium.org/2782403002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/dom/ModuleScript.h:72: m_instantiationError(this), Why "this"?
https://codereview.chromium.org/2782403002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/dom/ModuleScript.h (right): https://codereview.chromium.org/2782403002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/dom/ModuleScript.h:72: m_instantiationError(this), On 2017/04/05 08:26:11, domenic wrote: > Why "this"? TraceWrapperV8Reference c-tor takes m_parent as an arg. In this case, this == ModuleScript is m_parent for the TraceWrapperV8Reference m_instantiationError.
LGTM. Can we add a test to check that the error object is not gone after triggering a GC?
On 2017/04/05 11:51:50, haraken wrote: > LGTM. > > Can we add a test to check that the error object is not gone after triggering a > GC? I'd like to do this from ModuleMapTest which owns ModuleScript through ::Entry. Let me follow up in separate CL
On 2017/04/05 12:07:19, kouhei wrote: > On 2017/04/05 11:51:50, haraken wrote: > > LGTM. > > > > Can we add a test to check that the error object is not gone after triggering > a > > GC? > > I'd like to do this from ModuleMapTest which owns ModuleScript through ::Entry. > Let me follow up in separate CL ok
The CQ bit was checked by kouhei@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491397375929330,
"parent_rev": "87a81cefcde85135ccec1147a31b9fa18c375f3f", "commit_rev":
"6ea86583949ca6e382e3e481243236619359f29c"}
Message was sent while issue was closed.
Description was changed from ========== [ES6 modules] Implement #concept-module-script-instantiation-error This CL implements the spec concept "instantiation error" as ModuleScript::m_instantiationError. https://html.spec.whatwg.org/multipage/webappapis.html#concept-module-script-... BUG=594639 ========== to ========== [ES6 modules] Implement #concept-module-script-instantiation-error This CL implements the spec concept "instantiation error" as ModuleScript::m_instantiationError. https://html.spec.whatwg.org/multipage/webappapis.html#concept-module-script-... BUG=594639 Review-Url: https://codereview.chromium.org/2782403002 Cr-Commit-Position: refs/heads/master@{#462099} Committed: https://chromium.googlesource.com/chromium/src/+/6ea86583949ca6e382e3e4812432... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/6ea86583949ca6e382e3e4812432... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
