Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2782393004: MD Settings: Restore focus after closing dialogs, for startup page. (Closed)

Created:
3 years, 8 months ago by dpapad
Modified:
3 years, 8 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Restore focus after closing dialogs, for startup page. BUG=668313 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2782393004 Cr-Commit-Position: refs/heads/master@{#461212} Committed: https://chromium.googlesource.com/chromium/src/+/31a445667f4fddb5c78a464a4de52f000777a74a

Patch Set 1 #

Patch Set 2 : More #

Patch Set 3 : Fix compiler #

Patch Set 4 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M chrome/browser/resources/settings/on_startup_page/startup_url_entry.js View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_urls_page.js View 1 2 3 chunks +14 lines, -1 line 0 comments Download
M chrome/test/data/webui/settings/startup_urls_page_test.js View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
dpapad
3 years, 8 months ago (2017-03-31 01:57:57 UTC) #5
dschuyler
lgtm
3 years, 8 months ago (2017-03-31 19:10:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782393004/60001
3 years, 8 months ago (2017-03-31 19:24:07 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 20:40:03 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/31a445667f4fddb5c78a464a4de5...

Powered by Google App Engine
This is Rietveld 408576698