Omnibox Metrics - Record Clipboard URL Impressions

Omnibox Metrics - Record Clipboard URL Impressions

Not tested, as this provider is only implemented on an iOS device and I don't have one.  I'm pretty sure this is straightforward enough to work right. :-)  [famous last words]

BUG=704715
Review-Url: https://codereview.chromium.org/2782393003
Cr-Commit-Position: refs/heads/master@{#461161}
Committed: https://chromium.googlesource.com/chromium/src/+/ab3761497a481d8b747d3e7342e8fbe8768fef4b

[Mark P, 2017-03-30 21:10:20]

The CQ bit was checked by mpearson@chromium.org to run a CQ dry run

[Mark P, 2017-03-30 21:10:49]

Description was changed from

==========
Omnibox Metrics - Record Clipboard URL Impressions

BUG=704715
==========

to

==========
Omnibox Metrics - Record Clipboard URL Impressions

BUG=704715
==========

[Mark P, 2017-03-30 21:10:49]

mpearson@chromium.org changed reviewers:
+ isherman@chromium.org, jif@chromium.org

[Mark P, 2017-03-30 21:11:49]

Description was changed from

==========
Omnibox Metrics - Record Clipboard URL Impressions

BUG=704715
==========

to

==========
Omnibox Metrics - Record Clipboard URL Impressions

Not tested, as this provider is only implemented on an iOS device and I don't
have one.  I'm pretty sure this is straightforward enough to work right. :-) 
[famous last words]

BUG=704715
==========

[commit-bot: I haz the power, 2017-03-30 21:11:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark P, 2017-03-30 21:12:06]

jif@,

Can you review the histogram?

isherman@,

Can you review histograms.xml?

thanks all,
mark

[Ilya Sherman, 2017-03-30 21:58:10]

LGTM

[commit-bot: I haz the power, 2017-03-30 22:55:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 22:55:03]

Dry run: This issue passed the CQ dry run.

[Mark P, 2017-03-31 04:19:54]

Ilya, I expanded the histogram description.  Can you please take another look to
make sure it makes sense?

thanks,
mark

[jif, 2017-03-31 09:11:29]

On 2017/03/31 04:19:54, Mark P wrote:
> Ilya, I expanded the histogram description.  Can you please take another look
to
> make sure it makes sense?
> 
> thanks,
> mark

lgtm

Tested on iOS: it works.
|matches_| is empty when on NTP. |matches_| not empty when not on NTP.

[Mark P, 2017-03-31 16:13:01]

The CQ bit was checked by mpearson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 16:13:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ilya Sherman, 2017-03-31 16:52:43]

https://codereview.chromium.org/2782393003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2782393003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:44241: +    and
MobileFocusedOmniboxNotOnNtp.
I wouldn't normally recommend comparing histograms against user actions.  At
least in the past, we saw significant skew between them.  I'm not sure whether
that's 100% better now, even with Rob's changes around when we drop metrics.

[Mark P, 2017-03-31 16:54:43]

https://codereview.chromium.org/2782393003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2782393003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:44241: +    and
MobileFocusedOmniboxNotOnNtp.
On 2017/03/31 16:52:43, Ilya Sherman wrote:
> I wouldn't normally recommend comparing histograms against user actions.  At
> least in the past, we saw significant skew between them.  I'm not sure whether
> that's 100% better now, even with Rob's changes around when we drop metrics.

Good point.

That said, I sanity-checked using the counts of user actions and comparing them
to omnibox events, and the the ratio is right around what I'd expect.

[Ilya Sherman, 2017-03-31 16:56:05]

https://codereview.chromium.org/2782393003/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2782393003/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:44241: +    and
MobileFocusedOmniboxNotOnNtp.
On 2017/03/31 16:54:42, Mark P wrote:
> On 2017/03/31 16:52:43, Ilya Sherman wrote:
> > I wouldn't normally recommend comparing histograms against user actions.  At
> > least in the past, we saw significant skew between them.  I'm not sure
whether
> > that's 100% better now, even with Rob's changes around when we drop metrics.
> 
> Good point.
> 
> That said, I sanity-checked using the counts of user actions and comparing
them
> to omnibox events, and the the ratio is right around what I'd expect.

Okay.  As long as you're comfortable with that potential skew, LGTM.

[Mark P, 2017-03-31 17:03:47]

On 2017/03/31 16:56:05, Ilya Sherman wrote:
>
https://codereview.chromium.org/2782393003/diff/20001/tools/metrics/histogram...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://codereview.chromium.org/2782393003/diff/20001/tools/metrics/histogram...
> tools/metrics/histograms/histograms.xml:44241: +    and
> MobileFocusedOmniboxNotOnNtp.
> On 2017/03/31 16:54:42, Mark P wrote:
> > On 2017/03/31 16:52:43, Ilya Sherman wrote:
> > > I wouldn't normally recommend comparing histograms against user actions. 
At
> > > least in the past, we saw significant skew between them.  I'm not sure
> whether
> > > that's 100% better now, even with Rob's changes around when we drop
metrics.
> > 
> > Good point.
> > 
> > That said, I sanity-checked using the counts of user actions and comparing
> them
> > to omnibox events, and the the ratio is right around what I'd expect.
> 
> Okay.  As long as you're comfortable with that potential skew, LGTM.

I am.  Thanks for the warning reminder.

--mark

[commit-bot: I haz the power, 2017-03-31 17:21:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 17:21:05]

Dry run: This issue passed the CQ dry run.

[Mark P, 2017-03-31 17:21:24]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2017-03-31 17:21:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 17:29:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490980884687700,
"parent_rev": "10680ded1bf7a68d8f9a05dd8dd9b378817bbe1b", "commit_rev":
"ab3761497a481d8b747d3e7342e8fbe8768fef4b"}

[commit-bot: I haz the power, 2017-03-31 17:30:52]

Description was changed from

==========
Omnibox Metrics - Record Clipboard URL Impressions

Not tested, as this provider is only implemented on an iOS device and I don't
have one.  I'm pretty sure this is straightforward enough to work right. :-) 
[famous last words]

BUG=704715
==========

to

==========
Omnibox Metrics - Record Clipboard URL Impressions

Not tested, as this provider is only implemented on an iOS device and I don't
have one.  I'm pretty sure this is straightforward enough to work right. :-) 
[famous last words]

BUG=704715

Review-Url: https://codereview.chromium.org/2782393003
Cr-Commit-Position: refs/heads/master@{#461161}
Committed:
https://chromium.googlesource.com/chromium/src/+/ab3761497a481d8b747d3e7342e8...
==========

[commit-bot: I haz the power, 2017-03-31 17:30:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ab3761497a481d8b747d3e7342e8...