make doc/recipes.py supported version 1 and 2

make doc/recipes.py supported version 1 and 2

R=dnj@chromium.org, nodir@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2782323002
Committed: https://github.com/luci/recipes-py/commit/e77477ba61ef082e2e34d58fd1251a1cb707f698

[iannucci, 2017-03-29 22:15:09]

https://codereview.chromium.org/2782323002/diff/20001/doc/recipes.py
File doc/recipes.py (right):

https://codereview.chromium.org/2782323002/diff/20001/doc/recipes.py#newcode70
doc/recipes.py:70: if pb['api_version'] == 1:
This section will go away when we only support version 2

https://codereview.chromium.org/2782323002/diff/20001/unittests/repo_test_uti...
File unittests/repo_test_util.py (right):

https://codereview.chromium.org/2782323002/diff/20001/unittests/repo_test_uti...
unittests/repo_test_util.py:134: api_version=2,
this makes the autoroll tests emit version 2 json.

[nodir, 2017-03-29 22:15:53]

lgtm

[dnj, 2017-03-29 22:16:15]

lgtm w/ comment

https://codereview.chromium.org/2782323002/diff/20001/doc/recipes.py
File doc/recipes.py (right):

https://codereview.chromium.org/2782323002/diff/20001/doc/recipes.py#newcode70
doc/recipes.py:70: if pb['api_version'] == 1:
On 2017/03/29 22:15:08, iannucci wrote:
> This section will go away when we only support version 2

Add a TODO then?

https://codereview.chromium.org/2782323002/diff/20001/unittests/repo_test_uti...
File unittests/repo_test_util.py (right):

https://codereview.chromium.org/2782323002/diff/20001/unittests/repo_test_uti...
unittests/repo_test_util.py:134: api_version=2,
On 2017/03/29 22:15:08, iannucci wrote:
> this makes the autoroll tests emit version 2 json.

Acknowledged.

[iannucci, 2017-03-29 22:17:20]

https://codereview.chromium.org/2782323002/diff/20001/doc/recipes.py
File doc/recipes.py (right):

https://codereview.chromium.org/2782323002/diff/20001/doc/recipes.py#newcode70
doc/recipes.py:70: if pb['api_version'] == 1:
On 2017/03/29 22:16:15, dnj wrote:
> On 2017/03/29 22:15:08, iannucci wrote:
> > This section will go away when we only support version 2
> 
> Add a TODO then?

Done

[iannucci, 2017-03-29 22:17:37]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2017-03-29 22:17:38]

The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org,
nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2782323002/#ps40001
(title: "todo")

[commit-bot: I haz the power, 2017-03-29 22:17:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 22:21:38]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490825857728810,
"parent_rev": "855168108b3dab668c36b56a99ca5a73f6d98932", "commit_rev":
"e77477ba61ef082e2e34d58fd1251a1cb707f698"}

[commit-bot: I haz the power, 2017-03-29 22:21:42]

Description was changed from

==========
make doc/recipes.py supported version 1 and 2

R=dnj@chromium.org, nodir@chromium.org
BUG=
==========

to

==========
make doc/recipes.py supported version 1 and 2

R=dnj@chromium.org, nodir@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2782323002
Committed:
https://github.com/luci/recipes-py/commit/e77477ba61ef082e2e34d58fd1251a1cb70...
==========

[commit-bot: I haz the power, 2017-03-29 22:21:42]

Committed patchset #3 (id:40001) as
https://github.com/luci/recipes-py/commit/e77477ba61ef082e2e34d58fd1251a1cb70...