Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2782283002: Rebaseline images/color-profile-layer.html (Closed)

Created:
3 years, 8 months ago by Stephen Chennney
Modified:
3 years, 8 months ago
Reviewers:
Noel Gordon
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebaseline images/color-profile-layer.html The virtual/gpu version always passes, so the test is possibly not flaky. Need to find out. TBR=noel@chromium.org BUG=657839 Review-Url: https://codereview.chromium.org/2782283002 Cr-Commit-Position: refs/heads/master@{#461164} Committed: https://chromium.googlesource.com/chromium/src/+/0e057a053294f528b4efb00b4f1e0f776e4afc16

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/images/color-profile-layer-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/images/color-profile-layer-expected.png View 1 Binary file 0 comments Download

Messages

Total messages: 11 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782283002/20001
3 years, 8 months ago (2017-03-31 17:28:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/0e057a053294f528b4efb00b4f1e0f776e4afc16
3 years, 8 months ago (2017-03-31 17:39:37 UTC) #9
Noel Gordon
3 years, 8 months ago (2017-04-03 03:22:24 UTC) #11
Thanks.  Looking at:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType...

doesn't appear to be flaky at all.  Load an image, then give it a composited
layer using CSS translateZ(0), and end of test.  Standard web use and I have a
hard time understanding why the test was marked flakey in the first place.

Anyho, LGTM and thanks for re-enabling the test.

Powered by Google App Engine
This is Rietveld 408576698