Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2782203003: [Extensions Schema Compiler] Don't bundle nocompile and jsexterns keys (Closed)

Created:
3 years, 8 months ago by Devlin
Modified:
3 years, 8 months ago
Reviewers:
lazyboy
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Schema Compiler] Don't bundle nocompile and jsexterns keys BUG=706480 Review-Url: https://codereview.chromium.org/2782203003 Cr-Commit-Position: refs/heads/master@{#460463} Committed: https://chromium.googlesource.com/chromium/src/+/a3911c42a8ec4d0f164a77ff99b723d2fde12754

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M tools/json_schema_compiler/cpp_bundle_generator.py View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Devlin
3 years, 8 months ago (2017-03-29 18:10:14 UTC) #7
lazyboy
lgtm
3 years, 8 months ago (2017-03-29 18:11:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782203003/1
3 years, 8 months ago (2017-03-29 18:18:35 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 18:28:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a3911c42a8ec4d0f164a77ff99b7...

Powered by Google App Engine
This is Rietveld 408576698