Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2782153002: Fix for performance regression on high dpi devices. (Closed)

Created:
3 years, 8 months ago by Karl Øygard
Modified:
3 years, 8 months ago
Reviewers:
rune
CC:
chromium-reviews, blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for performance regression on high dpi devices. ComputedStyle::getRoundedInnerBorderFor() could generate negative content boxes for boxes with no content and sub pixel borders that round up (eg. 1.5px-1.99px). Negative content boxes are illegal per spec, and causes BoxBorderPainter::paintBorderFastPath() to bail, and performance to be substantially degraded. This issue would be evident on the paint-offset-changes perftest when device pixel ratio was set to eg. 1.5. The issue was introduced in 934becac5daa91ea979fb66e4ae21761ca11ebc9 BUG=692955 Review-Url: https://codereview.chromium.org/2782153002 Cr-Commit-Position: refs/heads/master@{#460534} Committed: https://chromium.googlesource.com/chromium/src/+/501d97b0c948ca7c5056016083ec5279ce1edf84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (8 generated)
rune
lgtm
3 years, 8 months ago (2017-03-29 20:36:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782153002/1
3 years, 8 months ago (2017-03-29 20:46:00 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 21:00:38 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/501d97b0c948ca7c5056016083ec...

Powered by Google App Engine
This is Rietveld 408576698