Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2782143003: [turbofan] Inline calls to the Boolean constructor. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Inline calls to the Boolean constructor. Recognize the Boolean constructor calls in JSCallReducer and replace them with simple JSToBoolean nodes. R=yangguo@chromium.org BUG=v8:5267, v8:6169 Review-Url: https://codereview.chromium.org/2782143003 Cr-Commit-Position: refs/heads/master@{#44259} Committed: https://chromium.googlesource.com/v8/v8/+/36d4ba623346b370c5470da74d4d0db49f4635c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/compiler/js-call-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Benedikt Meurer
3 years, 8 months ago (2017-03-29 19:13:11 UTC) #1
Benedikt Meurer
Hey Michael, Here's a trivial one. Apparently people (and as I learned today tools) use ...
3 years, 8 months ago (2017-03-29 19:15:07 UTC) #5
mvstanton
Interesting! Very good, LGTM.
3 years, 8 months ago (2017-03-29 20:18:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782143003/1
3 years, 8 months ago (2017-03-30 03:58:05 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 03:59:24 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/36d4ba623346b370c5470da74d4d0db49f4...

Powered by Google App Engine
This is Rietveld 408576698