Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2782103002: Fix typo in OWNERS for flag_descriptions (Closed)

Created:
3 years, 8 months ago by vabr (Chromium)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, Ilya Sherman, marq+watch_chromium.org, noyau+watch_chromium.org, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in OWNERS for flag_descriptions Turns out https://codereview.chromium.org/2774203002 landed with a typo in OWNERS files, mentioning "flags" instead of "flag" in the flag description file names. This has been discovered and fixed for //chrome by isherman in https://codereview.chromium.org/2784723002/. It also needs fixing in iOS. To speed up the fix, I am uploading this CL with both the //chrome and //ios correction. BUG=703134 TBR=sdefresne@chromium.org Review-Url: https://codereview.chromium.org/2782103002 Cr-Commit-Position: refs/heads/master@{#460325} Committed: https://chromium.googlesource.com/chromium/src/+/47f8634a9cd73ded68ee3e5f2c0de85a868396b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/OWNERS View 2 chunks +1 line, -2 lines 0 comments Download
M ios/chrome/browser/OWNERS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
vabr (Chromium)
Hi all! jochen@ -- please rubberstamp //chrome/browser/OWNERS. sdefresne@ -- please rubberstamp //ios/chrome/browser/OWNERS. Thanks! Vaclav
3 years, 8 months ago (2017-03-29 06:41:37 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-03-29 06:43:17 UTC) #5
vabr (Chromium)
I'm adding sdefresne@ in TBR and landing this now, as it is blocking others (see ...
3 years, 8 months ago (2017-03-29 08:08:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782103002/1
3 years, 8 months ago (2017-03-29 08:09:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/47f8634a9cd73ded68ee3e5f2c0de85a868396b0
3 years, 8 months ago (2017-03-29 08:14:21 UTC) #14
sdefresne
3 years, 8 months ago (2017-03-29 08:15:43 UTC) #15
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698