Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2782093002: Move tests for <menu> and <menuitem> to LayoutTests/html/menu_menuitem/. (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
kochi
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move tests for <menu> and <menuitem> to LayoutTests/html/menu_menuitem/. BUG=685886 TBR=kochi@chromium.org Review-Url: https://codereview.chromium.org/2782093002 Cr-Commit-Position: refs/heads/master@{#460300} Committed: https://chromium.googlesource.com/chromium/src/+/ff68448ed0bfa7262ed849bf7415f9a22ae98a81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -398 lines) Patch
D third_party/WebKit/LayoutTests/fast/dom/HTMLMenuElement/custom-context-menu.html View 1 chunk +0 lines, -200 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLMenuElement/custom-context-menu-expected.txt View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLMenuElement/menu-type-popup.html View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLMenuElement/menu-type-popup-expected.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLMenuItemElement/menuitem-click.html View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLMenuItemElement/menuitem-click-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLMenuItemElement/menuitem-crash-asan.html View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLMenuItemElement/menuitem-crash-asan-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLMenuItemElement/menuitem-with-end-tag.html View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/HTMLMenuItemElement/menuitem-with-end-tag-expected.html View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/html/README.md View 1 chunk +4 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/menu_menuitem/custom-context-menu.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/html/menu_menuitem/custom-context-menu-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/menu_menuitem/menu-type-popup.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/menu_menuitem/menu-type-popup-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/menu_menuitem/menuitem-click.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/html/menu_menuitem/menuitem-click-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/menu_menuitem/menuitem-crash-asan.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/menu_menuitem/menuitem-crash-asan-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/menu_menuitem/menuitem-with-end-tag.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/menu_menuitem/menuitem-with-end-tag-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
tkent
3 years, 8 months ago (2017-03-29 05:50:50 UTC) #3
kochi
LGTM
3 years, 8 months ago (2017-03-29 05:51:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782093002/1
3 years, 8 months ago (2017-03-29 05:51:19 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 06:26:58 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ff68448ed0bfa7262ed849bf7415...

Powered by Google App Engine
This is Rietveld 408576698