Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2612)

Unified Diff: build/config/compiler/compiler.gni

Issue 2782063005: Explicitly specify whether to emit frame pointers by default. (Closed)
Patch Set: Clean up. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/compiler/compiler.gni
diff --git a/build/config/compiler/compiler.gni b/build/config/compiler/compiler.gni
index 403dd4fd320e37951467fadc5c3a116e92405bf5..31f62098ea1c1769cfb6cd53d3f25e0504155a33 100644
--- a/build/config/compiler/compiler.gni
+++ b/build/config/compiler/compiler.gni
@@ -65,6 +65,25 @@ declare_args() {
use_pic = true
}
+# Whether to emit frame pointers by default.
+if (is_mac || is_ios) {
+ enabled_frame_pointers = true
+} else if (is_win) {
+ # 64-bit Windows ABI doesn't support frame pointers.
+ if (target_cpu == "x64") {
+ enabled_frame_pointers = false
+ } else {
+ enabled_frame_pointers = true
+ }
+} else {
+ # Explicitly ask for frame pointers, otherwise:
+ # * Stacks may be missing for sanitizer and profiling builds.
+ # * Debug tcmalloc can crash (crbug.com/636489).
+ # * Stacks may be missing for arm64 crash dumps (crbug.com/391706).
+ enabled_frame_pointers =
+ using_sanitizer || enable_profiling || is_debug || current_cpu == "arm64"
+}
+
declare_args() {
# Whether or not the official builds should be built with full WPO. Enabled by
# default for the PGO and the x64 builds.

Powered by Google App Engine
This is Rietveld 408576698