chrome/browser/chromeos/libc_close_tracking.cc - Issue 2782063005: Explicitly specify whether to emit frame pointers by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/libc_close_tracking.cc

Issue 2782063005: Explicitly specify whether to emit frame pointers by default. (Closed)

Patch Set: Clean up. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/libc_close_tracking.cc

diff --git a/chrome/browser/chromeos/libc_close_tracking.cc b/chrome/browser/chromeos/libc_close_tracking.cc

index 260a116b5a2e664ed3e7064d42af3ccc765f6882..28e13d34be883f289546d17de538700e5abf44d9 100644

--- a/chrome/browser/chromeos/libc_close_tracking.cc

+++ b/chrome/browser/chromeos/libc_close_tracking.cc

@@ -119,7 +119,7 @@ int CloseOverride(int fd) {

// Capture stack for successful close.

if (ret == 0) {

-#if HAVE_TRACE_STACK_FRAME_POINTERS && !defined(MEMORY_SANITIZER)

+#if CAN_UNWIND_WITH_FRAME_POINTERS && !defined(MEMORY_SANITIZER)

// Use TraceStackFramePointers because the backtrack() based default

// capturing gets only the last stack frame and is not useful.

// With the exception of when MSAN is enabled. See comments for why