Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 278203002: gerrit_util is aware of auth errors (Closed)

Created:
6 years, 7 months ago by nodir
Modified:
6 years, 7 months ago
Reviewers:
Vadim Sh., szager1
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

gerrit_util is aware of auth errors gerrit_util raises GerritAuthenticationError with a nice message suggesting to check the .netrc file. R=szager@chromium.org, vadimsh@chromium.org BUG=369512 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=269865

Patch Set 1 #

Patch Set 2 : Removed host from GerritAuthenticationError because it should be GerritError, out of scope of this … #

Total comments: 2

Patch Set 3 : moved auth check into the retry loop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M gerrit_util.py View 1 2 3 chunks +16 lines, -0 lines 0 comments Download
M trychange.py View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nodir
6 years, 7 months ago (2014-05-11 06:41:40 UTC) #1
szager1
https://codereview.chromium.org/278203002/diff/20003/gerrit_util.py File gerrit_util.py (right): https://codereview.chromium.org/278203002/diff/20003/gerrit_util.py#newcode148 gerrit_util.py:148: # Check if this is an authentication issue. Check ...
6 years, 7 months ago (2014-05-12 08:50:35 UTC) #2
nodir
https://codereview.chromium.org/278203002/diff/20003/gerrit_util.py File gerrit_util.py (right): https://codereview.chromium.org/278203002/diff/20003/gerrit_util.py#newcode148 gerrit_util.py:148: # Check if this is an authentication issue. On ...
6 years, 7 months ago (2014-05-12 18:11:20 UTC) #3
szager1
lgtm
6 years, 7 months ago (2014-05-12 18:33:48 UTC) #4
nodir
The CQ bit was checked by nodir@chromium.org
6 years, 7 months ago (2014-05-12 20:29:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nodir@chromium.org/278203002/30001
6 years, 7 months ago (2014-05-12 20:29:51 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 20:31:33 UTC) #7
Message was sent while issue was closed. 
Change committed as 269865

Powered by Google App Engine
This is Rietveld 408576698