gerrit_util is aware of auth errors

gerrit_util.py

 # Copyright (c) 2013 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 Utilities for requesting information for a gerrit server via https.
 
 https://gerrit-review.googlesource.com/Documentation/rest-api.html
 """
 
 import base64
 import httplib
 import json
 import logging
 import netrc
 import os
+import re
 import time
 import urllib
 from cStringIO import StringIO
 
 try:
   NETRC = netrc.netrc()
 except (IOError, netrc.NetrcParseError):
   NETRC = netrc.netrc(os.devnull)
 LOGGER = logging.getLogger()
 TRY_LIMIT = 5
 
 # Controls the transport protocol used to communicate with gerrit.
 # This is parameterized primarily to enable GerritTestCase.
 GERRIT_PROTOCOL = 'https'
 
 
 class GerritError(Exception):
   """Exception class for errors commuicating with the gerrit-on-borg service."""
   def __init__(self, http_status, *args, **kwargs):
     super(GerritError, self).__init__(*args, **kwargs)
     self.http_status = http_status
     self.message = '(%d) %s' % (self.http_status, self.message)
 
 
+class GerritAuthenticationError(GerritError):
+  """Exception class for authentication errors during Gerrit communication."""
+
+
 def _QueryString(param_dict, first_param=None):
   """Encodes query parameters in the key:val[+key:val...] format specified here:
 
   https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#list-changes
   """
   q = [urllib.quote(first_param)] if first_param else []
   q.extend(['%s:%s' % (key, val) for key, val in param_dict.iteritems()])
   return '+'.join(q)
 
 
@@ skipping 82 matching lines @@
       req_host = conn.req_host
       req_params = conn.req_params
       conn = GetConnectionClass()(req_host)
       conn.req_host = req_host
       conn.req_params = req_params
       conn.request(**req_params)
     LOGGER.warn(msg)
   if ignore_404 and response.status == 404:
     return StringIO()
   if response.status != expect_status:
+    # Check if this is an authentication issue.

[szager1, 2014/05/12 08:50:35]

Check this in the retry loop.  No sense in trying the request TRY_LIMIT times
when it's an authentication error.

[nodir, 2014/05/12 18:11:21]

Indeed. Done.

+    www_authenticate = response.getheader('www-authenticate')
+    if (response.status in (httplib.UNAUTHORIZED, httplib.FOUND) and
+        www_authenticate):
+      auth_match = re.search('realm="([^"]+)"', www_authenticate, re.I)
+      host = auth_match.group(1) if auth_match else req_host
+      reason = ('Authentication failed. Please make sure your .netrc file '
+                'has credentials for %s' % host)
+      raise GerritAuthenticationError(response.status, reason)
+
     reason = '%s: %s' % (response.reason, response.read())
     raise GerritError(response.status, reason)
   return StringIO(response.read())
 
 
 def ReadHttpJsonResponse(conn, expect_status=200, ignore_404=True):
   """Parses an https response as json."""
   fh = ReadHttpResponse(
       conn, expect_status=expect_status, ignore_404=ignore_404)
   # The first line of the response should always be: )]}'
@@ skipping 277 matching lines @@
         username = review.get('email', jmsg.get('name', ''))
         raise GerritError(200, 'Unable to set %s label for user "%s"'
                        ' on change %s.' % (label, username, change))
   jmsg = GetChangeCurrentRevision(host, change)
   if not jmsg:
     raise GerritError(
         200, 'Could not get review information for change "%s"' % change)
   elif jmsg[0]['current_revision'] != revision:
     raise GerritError(200, 'While resetting labels on change "%s", '
                    'a new patchset was uploaded.' % change)