Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(193)

Issue 2781993006: Use new APIs for parsing encrypted ECPrivateKeys. (Closed)

Created:
3 years, 5 months ago by davidben
Modified:
3 years, 5 months ago
Reviewers:
svaldez
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use new APIs for parsing encrypted ECPrivateKeys. These APIs don't depend on the giant OID table and are much easier to use. BUG=706445 Review-Url: https://codereview.chromium.org/2781993006 Cr-Commit-Position: refs/heads/master@{#461539} Committed: https://chromium.googlesource.com/chromium/src/+/b8adc35a73c0c9981d9d26e34de07e0d0600dcbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -75 lines) Patch
M crypto/ec_private_key.cc View 3 chunks +32 lines, -75 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (10 generated)
davidben
3 years, 5 months ago (2017-03-29 16:53:10 UTC) #4
svaldez
lgtm
3 years, 5 months ago (2017-04-03 19:22:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781993006/1
3 years, 5 months ago (2017-04-03 19:24:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/185907)
3 years, 5 months ago (2017-04-03 20:24:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781993006/1
3 years, 5 months ago (2017-04-03 20:29:32 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-04-03 21:11:24 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b8adc35a73c0c9981d9d26e34de0...

Powered by Google App Engine
This is Rietveld 408576698