Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2781993003: Move tests for Attr interface to LayoutTests/dom/attr/. (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
kochi
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move tests for Attr interface to LayoutTests/dom/attr/. BUG=685886 TBR=kochi@chromium.org Review-Url: https://codereview.chromium.org/2781993003 Cr-Commit-Position: refs/heads/master@{#460318} Committed: https://chromium.googlesource.com/chromium/src/+/d9eef669c7b792da254dbb6dc71a0b770bc7201f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -378 lines) Patch
M third_party/WebKit/LayoutTests/dom/README.md View 1 chunk +4 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/dom/attr/access-after-element-destruction.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/dom/attr/access-after-element-destruction-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/dom/attr/change-id-via-attr-node-value.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/dom/attr/change-id-via-attr-node-value-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/dom/attr/direction-attribute-set-and-cleared.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/dom/attr/direction-attribute-set-and-cleared-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/dom/attr/parent-adopt-node.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/dom/attr/parent-adopt-node-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/dom/attr/set-attr-value-no-DOMSubtreeModified.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/dom/attr/set-attr-value-no-DOMSubtreeModified-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/dom/attr/set-attribute-node-from-iframe.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/dom/attr/set-attribute-node-from-iframe-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/dom/attr/update-attribute-node-no-crash.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/dom/attr/update-attribute-node-no-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Attr/access-after-element-destruction.html View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Attr/access-after-element-destruction-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Attr/change-id-via-attr-node-value.html View 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Attr/change-id-via-attr-node-value-expected.txt View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Attr/direction-attribute-set-and-cleared.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Attr/direction-attribute-set-and-cleared-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Attr/parent-adopt-node.html View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Attr/parent-adopt-node-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Attr/set-attr-value-no-DOMSubtreeModified.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Attr/set-attr-value-no-DOMSubtreeModified-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Attr/set-attribute-node-from-iframe.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Attr/set-attribute-node-from-iframe-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Attr/update-attribute-node-no-crash.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Attr/update-attribute-node-no-crash-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
tkent
3 years, 8 months ago (2017-03-29 07:29:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781993003/1
3 years, 8 months ago (2017-03-29 07:29:35 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d9eef669c7b792da254dbb6dc71a0b770bc7201f
3 years, 8 months ago (2017-03-29 07:34:28 UTC) #10
kochi
3 years, 8 months ago (2017-03-29 07:41:47 UTC) #11
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698