Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2781943002: Convert AudioNode tests to new Audit (Closed)

Created:
3 years, 8 months ago by Raymond Toy
Modified:
3 years, 8 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert AudioNode tests to new Audit Manually converted test to use new Audit. BUG=704967 TEST=AudioNode/audionode-connect-method-chaining.html AudioNode/audionode-disconnect-audioparam.html AudioNode/audionode-disconnect.html AudioNode/channel-mode-interp-basic.html Review-Url: https://codereview.chromium.org/2781943002 Cr-Commit-Position: refs/heads/master@{#461873} Committed: https://chromium.googlesource.com/chromium/src/+/b8a3aab2bfabcf85262d12768bae81f10f913218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -130 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-connect-method-chaining.html View 8 chunks +27 lines, -40 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-disconnect.html View 9 chunks +41 lines, -47 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-disconnect-audioparam.html View 5 chunks +20 lines, -31 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioNode/channel-mode-interp-basic.html View 2 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Raymond Toy
PTAL
3 years, 8 months ago (2017-04-04 21:06:32 UTC) #2
hongchan
lgtm
3 years, 8 months ago (2017-04-04 21:19:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781943002/1
3 years, 8 months ago (2017-04-04 21:26:59 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 22:40:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b8a3aab2bfabcf85262d12768bae...

Powered by Google App Engine
This is Rietveld 408576698