Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2781913002: Change ITestClient to be similar to IChildProcessService. (Closed)

Created:
3 years, 8 months ago by Jay Civelli
Modified:
3 years, 8 months ago
Reviewers:
nyquist
CC:
chromium-reviews, agrieve+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change ITestClient to be similar to IChildProcessService. Preparing the MultiprocessTestClientLauncher for transitioning to the new base ChildProcessLauncher. More specifically, making ITestClient similar to IChildProcessService. This requires moving extra methods to a new interface ITestController, and creating a callback interface ITestCallback that lets the service sets the ITestController interface on the client. BUG=702316 Review-Url: https://codereview.chromium.org/2781913002 Cr-Commit-Position: refs/heads/master@{#462683} Committed: https://chromium.googlesource.com/chromium/src/+/9bd4d39997fab20c32cd0c7a75c45dbcf3f00642

Patch Set 1 #

Patch Set 2 : Clean-up. #

Total comments: 8

Patch Set 3 : Addressed nyquist@'s comments. #

Patch Set 4 : Fix compile error sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -75 lines) Patch
M base/test/BUILD.gn View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
A base/test/android/java/src/org/chromium/base/ChildProcessConstants.java View 1 chunk +16 lines, -0 lines 0 comments Download
A base/test/android/java/src/org/chromium/base/ITestCallback.aidl View 1 chunk +16 lines, -0 lines 0 comments Download
M base/test/android/java/src/org/chromium/base/ITestClient.aidl View 1 2 1 chunk +12 lines, -27 lines 0 comments Download
A + base/test/android/java/src/org/chromium/base/ITestController.aidl View 2 chunks +3 lines, -12 lines 0 comments Download
M base/test/android/java/src/org/chromium/base/MultiprocessTestClientLauncher.java View 1 2 3 7 chunks +36 lines, -13 lines 0 comments Download
M base/test/android/java/src/org/chromium/base/MultiprocessTestClientService.java View 3 chunks +61 lines, -23 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
Jay Civelli
3 years, 8 months ago (2017-03-29 20:12:04 UTC) #6
nyquist
https://codereview.chromium.org/2781913002/diff/20001/base/test/android/java/src/org/chromium/base/ITestClient.aidl File base/test/android/java/src/org/chromium/base/ITestClient.aidl (right): https://codereview.chromium.org/2781913002/diff/20001/base/test/android/java/src/org/chromium/base/ITestClient.aidl#newcode17 base/test/android/java/src/org/chromium/base/ITestClient.aidl:17: boolean bindToCaller(); Maybe I'm holding it wrong, but it ...
3 years, 8 months ago (2017-04-04 06:12:38 UTC) #10
Jay Civelli
https://codereview.chromium.org/2781913002/diff/20001/base/test/android/java/src/org/chromium/base/ITestClient.aidl File base/test/android/java/src/org/chromium/base/ITestClient.aidl (right): https://codereview.chromium.org/2781913002/diff/20001/base/test/android/java/src/org/chromium/base/ITestClient.aidl#newcode17 base/test/android/java/src/org/chromium/base/ITestClient.aidl:17: boolean bindToCaller(); On 2017/04/04 06:12:37, nyquist wrote: > Maybe ...
3 years, 8 months ago (2017-04-04 17:06:22 UTC) #11
nyquist
lgtm
3 years, 8 months ago (2017-04-05 17:59:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781913002/40001
3 years, 8 months ago (2017-04-05 18:02:34 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet/builds/113134)
3 years, 8 months ago (2017-04-05 18:12:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781913002/60001
3 years, 8 months ago (2017-04-06 22:07:08 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 23:38:22 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9bd4d39997fab20c32cd0c7a75c4...

Powered by Google App Engine
This is Rietveld 408576698