Properly clean up notification on download open

Properly clean up notification on download open

Now that downloads is a foreground service with the summary, we need to
manually clean up the summary in code, which means going through the
notification service to do it.

BUG=706094
Review-Url: https://codereview.chromium.org/2781873002
Cr-Commit-Position: refs/heads/master@{#460459}
Committed: https://chromium.googlesource.com/chromium/src/+/6d71d9c5b9a95b7476beefaa9ace1fc8b54d5b43

[David Trainor- moved to gerrit, 2017-03-28 16:03:03]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 16:03:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 16:41:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 16:41:48]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2017-03-28 18:44:55]

Description was changed from

==========
Properly clean up notification on download open

Now that downloads is a foreground service with the summary, we need to
manually clean up the summary in code, which means going through the
notification service to do it.

BUG=
==========

to

==========
Properly clean up notification on download open

Now that downloads is a foreground service with the summary, we need to
manually clean up the summary in code, which means going through the
notification service to do it.

BUG=706094
==========

[David Trainor- moved to gerrit, 2017-03-28 18:47:50]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[David Trainor- moved to gerrit, 2017-03-28 18:48:08]

dtrainor@chromium.org changed reviewers:
+ qinmin@chromium.org

[David Trainor- moved to gerrit, 2017-03-28 18:48:08]

ptal thanks

[commit-bot: I haz the power, 2017-03-28 18:48:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 19:54:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 19:54:08]

Dry run: This issue passed the CQ dry run.

[qinmin, 2017-03-28 23:58:57]

lgtm % nit

https://codereview.chromium.org/2781873002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/2781873002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:836:
public void removeDownloadNotification(String downloadGuid, int notificationId)
{
nit: can we just remove cancelNotification()? we only need 1 of these 2
functions

[David Trainor- moved to gerrit, 2017-03-29 16:33:47]

https://codereview.chromium.org/2781873002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/2781873002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:836:
public void removeDownloadNotification(String downloadGuid, int notificationId)
{
On 2017/03/28 23:58:57, qinmin wrote:
> nit: can we just remove cancelNotification()? we only need 1 of these 2
> functions

I'll just remove this one and make cancelNotification public.  Thanks!

[David Trainor- moved to gerrit, 2017-03-29 16:40:00]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 16:40:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Trainor- moved to gerrit, 2017-03-29 16:56:16]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 16:56:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 17:35:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 17:35:43]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2017-03-29 18:01:02]

The CQ bit was checked by dtrainor@chromium.org

[David Trainor- moved to gerrit, 2017-03-29 18:01:02]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org
Link to the patchset: https://codereview.chromium.org/2781873002/#ps100001
(title: "More rebase bugs")

[commit-bot: I haz the power, 2017-03-29 18:01:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 18:17:12]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490810462488330,
"parent_rev": "321152dcf0906133028c0e50559b8e5101260b48", "commit_rev":
"6d71d9c5b9a95b7476beefaa9ace1fc8b54d5b43"}

[commit-bot: I haz the power, 2017-03-29 18:18:29]

Description was changed from

==========
Properly clean up notification on download open

Now that downloads is a foreground service with the summary, we need to
manually clean up the summary in code, which means going through the
notification service to do it.

BUG=706094
==========

to

==========
Properly clean up notification on download open

Now that downloads is a foreground service with the summary, we need to
manually clean up the summary in code, which means going through the
notification service to do it.

BUG=706094

Review-Url: https://codereview.chromium.org/2781873002
Cr-Commit-Position: refs/heads/master@{#460459}
Committed:
https://chromium.googlesource.com/chromium/src/+/6d71d9c5b9a95b7476beefaa9ace...
==========

[commit-bot: I haz the power, 2017-03-29 18:18:34]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/6d71d9c5b9a95b7476beefaa9ace...