Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2781843002: Roll libxml to e905f08123e4a6e7731549e6f09dadff4cab65bd (Closed)

Created:
3 years, 8 months ago by dominicc (has gone to gerrit)
Modified:
3 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews, dominicc+watchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll libxml to e905f08123e4a6e7731549e6f09dadff4cab65bd In this patch I'm disabling LIBXML_VALID_ENABLED which should shrink the attack surface fuzzers find. Local patches we're no longer applying now: Issue 623378 Comment 7 has been fixed upstream: https://git.gnome.org/browse/libxml2/commit/?id=9ab01a277d71f54d3143c2cf333c5c2e9aaedd9e d31995076e55f1aac2f935c53b585a90ece27a11 / timsort.h: https://git.gnome.org/browse/libxml2/commit/?id=c2545cbb6d9a87e3e0bce167eabcb8f3c9153edc Issue 624011 was fixed upstream: https://git.gnome.org/browse/libxml2/commit/?id=c1d1f7121194036608bf555f08d3062a36fd344b BUG=705938, 692731 Review-Url: https://codereview.chromium.org/2781843002 Cr-Commit-Position: refs/heads/master@{#460360} Committed: https://chromium.googlesource.com/chromium/src/+/aa1586759de407c9631115b3de0ea85acb5b622f

Patch Set 1 #

Patch Set 2 : Add missing piece of acca03bd #

Patch Set 3 : Update README.chromium. #

Patch Set 4 : Make win32 also not define LIBXML_VALID_ENABLED. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1410 lines, -1440 lines) Patch
M third_party/libxml/README.chromium View 1 2 2 chunks +4 lines, -38 lines 0 comments Download
M third_party/libxml/linux/include/libxml/xmlversion.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/src/bakefile/Bakefiles.bkgen View 1 chunk +14 lines, -14 lines 0 comments Download
M third_party/libxml/src/bakefile/Readme.txt View 1 chunk +92 lines, -92 lines 0 comments Download
M third_party/libxml/src/bakefile/libxml2.bkl View 1 chunk +749 lines, -749 lines 0 comments Download
M third_party/libxml/src/libxml2.spec View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/src/macos/src/XMLTestPrefix.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/src/macos/src/XMLTestPrefix2.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/src/macos/src/libxml2_GUSIConfig.cp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/src/macos/src/macos_main.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/src/runtest.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/src/testlimits.c View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/libxml/src/timsort.h View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/libxml/src/win32/VC10/README.vc10 View 1 chunk +27 lines, -27 lines 0 comments Download
M third_party/libxml/src/win32/VC10/RuleSet1.ruleset View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libxml/src/xmlIO.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/src/xpath.c View 5 chunks +7 lines, -5 lines 0 comments Download
M third_party/libxml/src/xpointer.c View 5 chunks +11 lines, -9 lines 0 comments Download
M third_party/libxml/win32/xmlversion.h View 1 2 3 1 chunk +489 lines, -489 lines 0 comments Download

Messages

Total messages: 23 (19 generated)
dominicc (has gone to gerrit)
PTAL
3 years, 8 months ago (2017-03-28 13:08:14 UTC) #15
scottmg
lgtm
3 years, 8 months ago (2017-03-28 16:42:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781843002/60001
3 years, 8 months ago (2017-03-29 12:41:47 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 12:47:06 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/aa1586759de407c9631115b3de0e...

Powered by Google App Engine
This is Rietveld 408576698