Remove non-MD code for IME tray and tray menu.

Remove non-MD code for IME tray and tray menu.

BUG=686284, 686286
Review-Url: https://codereview.chromium.org/2781793002
Cr-Commit-Position: refs/heads/master@{#460477}
Committed: https://chromium.googlesource.com/chromium/src/+/a553b86b80c49a8e3d94774004b5c85ed09cf74a

[Evan Stade, 2017-03-28 02:19:27]

estade@chromium.org changed reviewers:
+ tdanderson@chromium.org

[Evan Stade, 2017-03-28 02:19:27]

depends on https://codereview.chromium.org/2778143002/

[tdanderson, 2017-03-28 22:30:39]

LGTM

https://codereview.chromium.org/2781793002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/ime_menu/ime_menu_tray.cc (right):

https://codereview.chromium.org/2781793002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:13: #include
"ash/common/system/tray/hover_highlight_view.h"
This can be deleted too

https://codereview.chromium.org/2781793002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/ime_menu/ime_menu_tray.h (right):

https://codereview.chromium.org/2781793002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/ime_menu/ime_menu_tray.h:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
nit: please add BUG=686286 to the CL description and take ownership of that bug.

Also update bug title to say you are also removing the pre-md code from the
opt-in IME menu

https://codereview.chromium.org/2781793002/diff/20001/ash/common/system/ime/t...
File ash/common/system/ime/tray_ime_chromeos.cc (right):

https://codereview.chromium.org/2781793002/diff/20001/ash/common/system/ime/t...
ash/common/system/ime/tray_ime_chromeos.cc:10: #include
"ash/common/system/tray/hover_highlight_view.h"
I think this can be removed too

[Evan Stade, 2017-03-28 22:47:40]

https://codereview.chromium.org/2781793002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/ime_menu/ime_menu_tray.cc (right):

https://codereview.chromium.org/2781793002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/ime_menu/ime_menu_tray.cc:13: #include
"ash/common/system/tray/hover_highlight_view.h"
On 2017/03/28 22:30:39, tdanderson wrote:
> This can be deleted too

Done.

https://codereview.chromium.org/2781793002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/ime_menu/ime_menu_tray.h (right):

https://codereview.chromium.org/2781793002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/ime_menu/ime_menu_tray.h:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
On 2017/03/28 22:30:39, tdanderson wrote:
> nit: please add BUG=686286 to the CL description and take ownership of that
bug.
> 

done

> Also update bug title to say you are also removing the pre-md code from the
> opt-in IME menu

what is the opt-in IME menu? Is it distinct fro ImeMenuTray?

https://codereview.chromium.org/2781793002/diff/20001/ash/common/system/ime/t...
File ash/common/system/ime/tray_ime_chromeos.cc (right):

https://codereview.chromium.org/2781793002/diff/20001/ash/common/system/ime/t...
ash/common/system/ime/tray_ime_chromeos.cc:10: #include
"ash/common/system/tray/hover_highlight_view.h"
On 2017/03/28 22:30:39, tdanderson wrote:
> I think this can be removed too

Done.

[Evan Stade, 2017-03-28 22:49:52]

Description was changed from

==========
Remove non-MD code for IME tray and tray menu.

BUG=686284
==========

to

==========
Remove non-MD code for IME tray and tray menu.

BUG=686284,686286
==========

[tdanderson, 2017-03-28 22:57:29]

https://codereview.chromium.org/2781793002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/ime_menu/ime_menu_tray.h (right):

https://codereview.chromium.org/2781793002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/ime_menu/ime_menu_tray.h:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
On 2017/03/28 22:47:39, Evan Stade wrote:
> On 2017/03/28 22:30:39, tdanderson wrote:
> > nit: please add BUG=686286 to the CL description and take ownership of that
> bug.
> > 
> 
> done
> 
> > Also update bug title to say you are also removing the pre-md code from the
> > opt-in IME menu
> 
> what is the opt-in IME menu? Is it distinct fro ImeMenuTray?

Hm, disregard, I think your CL title is sufficient as-is. "Opt-in IME menu" is I
believe the "official" feature name for ImeMenuTray, but this name only appears
in comments.

[Evan Stade, 2017-03-28 23:14:36]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-03-28 23:14:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2781793002/#ps60001
(title: "relative ps")

[commit-bot: I haz the power, 2017-03-28 23:15:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 23:46:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 23:46:43]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Evan Stade, 2017-03-29 17:50:25]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-03-29 17:50:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2781793002/#ps100001
(title: "actual rebase")

[commit-bot: I haz the power, 2017-03-29 17:50:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 19:04:59]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490809825439150,
"parent_rev": "2cf99830cfbe5d462b161089bb159ac9f29a620c", "commit_rev":
"a553b86b80c49a8e3d94774004b5c85ed09cf74a"}

[commit-bot: I haz the power, 2017-03-29 19:05:48]

Description was changed from

==========
Remove non-MD code for IME tray and tray menu.

BUG=686284,686286
==========

to

==========
Remove non-MD code for IME tray and tray menu.

BUG=686284,686286

Review-Url: https://codereview.chromium.org/2781793002
Cr-Commit-Position: refs/heads/master@{#460477}
Committed:
https://chromium.googlesource.com/chromium/src/+/a553b86b80c49a8e3d94774004b5...
==========

[commit-bot: I haz the power, 2017-03-29 19:05:51]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/a553b86b80c49a8e3d94774004b5...