Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2781783002: Allow webview guests to skip WAR checks in ShouldAllowOpenURL (Merge to M58) (Closed)

Created:
3 years, 8 months ago by alexmos
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Allow webview guests to skip WAR checks in ShouldAllowOpenURL (Merge to M58) Prior to r429532, the web-accessible resource checks in ShouldAllowOpenURL were skipped for all schemes other than HTTP/HTTPS/chrome-extension. After r429532, we've started enforcing them for most other schemes, but this breaks navigations from webview guests to webview-accessible app resources whenever those go through the OpenURL path, since the webview-accessible resource check is done separately later, in AllowCrossRendererResourceLoadHelper, and ShouldAllowOpenURL was killing the navigation before it ever got there. This CL will return webview guests to the previous behavior. BUG=691941 Review-Url: https://codereview.chromium.org/2766313002 Cr-Commit-Position: refs/heads/master@{#458959} (cherry picked from commit f89e04046aaac44ecad27056fb856c3d6e37370f) Review-Url: https://codereview.chromium.org/2781783002 . Cr-Commit-Position: refs/branch-heads/3029@{#447} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/32ec47289bec2eb6327723f491182e9f1c9a6103

Patch Set 1 #

Patch Set 2 : Allow webview guests to skip WAR checks in ShouldAllowOpenURL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/web_view/load_webview_accessible_resource/assets/foo.html View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/load_webview_accessible_resource/embedder.js View 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
alexmos
3 years, 8 months ago (2017-03-28 00:34:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
32ec47289bec2eb6327723f491182e9f1c9a6103.

Powered by Google App Engine
This is Rietveld 408576698