|
|
DescriptionAllow FreeType compilation and linkage from third_party on Windows
Create an OWNERS file for this directory and add myself as well. This is
preparation for using a shared FreeType between Blink and PDFium, but
not actually used as a depedency to any Windows targets yet.
BUG=700926
Review-Url: https://codereview.chromium.org/2781773003
Cr-Commit-Position: refs/heads/master@{#460211}
Committed: https://chromium.googlesource.com/chromium/src/+/e15f5107bfba9080481fd78ed35c69c81fc41ac3
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add Ben as additional owner #
Messages
Total messages: 25 (15 generated)
The CQ bit was checked by drott@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
drott@chromium.org changed reviewers: + dpranke@chromium.org, scottmg@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Allow FreeType compilation and linkage from third_party on Windows Create an OWNERS file for this directory and add myself as well. BUG=700926 ========== to ========== Allow FreeType compilation and linkage from third_party on Windows Create an OWNERS file for this directory and add myself as well. This is preparation for using a shared FreeType between Blink and PDFium, but not actually used as a depedency to any Windows targets yet. BUG=700926 ==========
lgtm
https://codereview.chromium.org/2781773003/diff/1/build/config/freetype/OWNERS File build/config/freetype/OWNERS (right): https://codereview.chromium.org/2781773003/diff/1/build/config/freetype/OWNER... build/config/freetype/OWNERS:1: drott@chromium.org Generally it's good to have at least two people in an OWNERS file, if you can convince someone else. :)
The CQ bit was checked by drott@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org Link to the patchset: https://codereview.chromium.org/2781773003/#ps20001 (title: "Add Ben as additional owner")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2781773003/diff/1/build/config/freetype/OWNERS File build/config/freetype/OWNERS (right): https://codereview.chromium.org/2781773003/diff/1/build/config/freetype/OWNER... build/config/freetype/OWNERS:1: drott@chromium.org On 2017/03/28 at 16:51:19, scottmg wrote: > Generally it's good to have at least two people in an OWNERS file, if you can convince someone else. :) I added Ben to the file, thanks for the review.
The CQ bit was checked by drott@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org Link to the patchset: https://codereview.chromium.org/2781773003/#ps40001 (title: "Add Ben as additional owner")
Patchset #2 (id:20001) has been deleted
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by drott@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490729211130170, "parent_rev": "cf65d881af4fe6daaee692153aaf78716e616860", "commit_rev": "e15f5107bfba9080481fd78ed35c69c81fc41ac3"}
Message was sent while issue was closed.
Description was changed from ========== Allow FreeType compilation and linkage from third_party on Windows Create an OWNERS file for this directory and add myself as well. This is preparation for using a shared FreeType between Blink and PDFium, but not actually used as a depedency to any Windows targets yet. BUG=700926 ========== to ========== Allow FreeType compilation and linkage from third_party on Windows Create an OWNERS file for this directory and add myself as well. This is preparation for using a shared FreeType between Blink and PDFium, but not actually used as a depedency to any Windows targets yet. BUG=700926 Review-Url: https://codereview.chromium.org/2781773003 Cr-Commit-Position: refs/heads/master@{#460211} Committed: https://chromium.googlesource.com/chromium/src/+/e15f5107bfba9080481fd78ed35c... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/e15f5107bfba9080481fd78ed35c...
Message was sent while issue was closed.
lgtm |