Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2781773003: Allow FreeType compilation and linkage from third_party on Windows (Closed)

Created:
3 years, 8 months ago by drott
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke, scottmg
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow FreeType compilation and linkage from third_party on Windows Create an OWNERS file for this directory and add myself as well. This is preparation for using a shared FreeType between Blink and PDFium, but not actually used as a depedency to any Windows targets yet. BUG=700926 Review-Url: https://codereview.chromium.org/2781773003 Cr-Commit-Position: refs/heads/master@{#460211} Committed: https://chromium.googlesource.com/chromium/src/+/e15f5107bfba9080481fd78ed35c69c81fc41ac3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add Ben as additional owner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M build/config/freetype/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A build/config/freetype/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
drott
3 years, 8 months ago (2017-03-28 14:53:46 UTC) #6
scottmg
lgtm
3 years, 8 months ago (2017-03-28 16:50:33 UTC) #8
scottmg
https://codereview.chromium.org/2781773003/diff/1/build/config/freetype/OWNERS File build/config/freetype/OWNERS (right): https://codereview.chromium.org/2781773003/diff/1/build/config/freetype/OWNERS#newcode1 build/config/freetype/OWNERS:1: drott@chromium.org Generally it's good to have at least two ...
3 years, 8 months ago (2017-03-28 16:51:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781773003/20001
3 years, 8 months ago (2017-03-28 17:29:25 UTC) #12
drott
https://codereview.chromium.org/2781773003/diff/1/build/config/freetype/OWNERS File build/config/freetype/OWNERS (right): https://codereview.chromium.org/2781773003/diff/1/build/config/freetype/OWNERS#newcode1 build/config/freetype/OWNERS:1: drott@chromium.org On 2017/03/28 at 16:51:19, scottmg wrote: > Generally ...
3 years, 8 months ago (2017-03-28 17:29:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781773003/40001
3 years, 8 months ago (2017-03-28 17:31:44 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/337499)
3 years, 8 months ago (2017-03-28 19:11:01 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781773003/40001
3 years, 8 months ago (2017-03-28 19:27:14 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/e15f5107bfba9080481fd78ed35c69c81fc41ac3
3 years, 8 months ago (2017-03-28 20:43:35 UTC) #24
Dirk Pranke
3 years, 8 months ago (2017-03-31 23:13:48 UTC) #25
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698