third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py - Issue 2781733003: Improve run-webkit-tests error reporting when ref tests have missing images.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

Issue 2781733003: Improve run-webkit-tests error reporting when ref tests have missing images. (Closed)

Patch Set: review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

index 59b6e450cd00a44e3f4ebf0a802fd8ae46fb6e9d..299f11a86ca7e41ed3281f0a513271d91b6c8976 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

@@ -160,7 +160,10 @@ def _interpret_test_failures(failures):

if test_failures.FailureMissingResult in failure_types:

test_dict['is_missing_text'] = True

- if test_failures.FailureMissingImage in failure_types or test_failures.FailureMissingImageHash in failure_types:

+ if (test_failures.FailureMissingImage in failure_types or

+ test_failures.FailureMissingImageHash in failure_types or

+ test_failures.FailureReftestNoImageGenerated in failure_types or

+ test_failures.FailureReftestNoReferenceImageGenerated in failure_types):

test_dict['is_missing_image'] = True

if test_failures.FailureTestHarnessAssertion in failure_types:

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py ('k') | no next file » | no next file with comments »