Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

Issue 2781733003: Improve run-webkit-tests error reporting when ref tests have missing images. (Closed)
Patch Set: review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # Copyright (C) 2010 Gabor Rapcsanyi (rgabor@inf.u-szeged.hu), University of Sze ged 2 # Copyright (C) 2010 Gabor Rapcsanyi (rgabor@inf.u-szeged.hu), University of Sze ged
3 # 3 #
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 test_dict = {} 153 test_dict = {}
154 failure_types = [type(failure) for failure in failures] 154 failure_types = [type(failure) for failure in failures]
155 # FIXME: get rid of all this is_* values once there is a 1:1 map between 155 # FIXME: get rid of all this is_* values once there is a 1:1 map between
156 # TestFailure type and test_expectations.EXPECTATION. 156 # TestFailure type and test_expectations.EXPECTATION.
157 if test_failures.FailureMissingAudio in failure_types: 157 if test_failures.FailureMissingAudio in failure_types:
158 test_dict['is_missing_audio'] = True 158 test_dict['is_missing_audio'] = True
159 159
160 if test_failures.FailureMissingResult in failure_types: 160 if test_failures.FailureMissingResult in failure_types:
161 test_dict['is_missing_text'] = True 161 test_dict['is_missing_text'] = True
162 162
163 if test_failures.FailureMissingImage in failure_types or test_failures.Failu reMissingImageHash in failure_types: 163 if (test_failures.FailureMissingImage in failure_types or
164 test_failures.FailureMissingImageHash in failure_types or
165 test_failures.FailureReftestNoImageGenerated in failure_types or
166 test_failures.FailureReftestNoReferenceImageGenerated in failure_typ es):
164 test_dict['is_missing_image'] = True 167 test_dict['is_missing_image'] = True
165 168
166 if test_failures.FailureTestHarnessAssertion in failure_types: 169 if test_failures.FailureTestHarnessAssertion in failure_types:
167 test_dict['is_testharness_test'] = True 170 test_dict['is_testharness_test'] = True
168 171
169 return test_dict 172 return test_dict
170 173
171 174
172 def summarize_results(port_obj, expectations, initial_results, 175 def summarize_results(port_obj, expectations, initial_results,
173 all_retry_results, enabled_pixel_tests_in_retry, 176 all_retry_results, enabled_pixel_tests_in_retry,
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 path = port_obj.repository_path() 346 path = port_obj.repository_path()
344 git = port_obj.host.git(path=path) 347 git = port_obj.host.git(path=path)
345 if git: 348 if git:
346 results['chromium_revision'] = str(git.commit_position(path)) 349 results['chromium_revision'] = str(git.commit_position(path))
347 else: 350 else:
348 _log.warning('Failed to determine chromium commit position for %s, ' 351 _log.warning('Failed to determine chromium commit position for %s, '
349 'leaving "chromium_revision" key blank in full_results. json.', 352 'leaving "chromium_revision" key blank in full_results. json.',
350 path) 353 path)
351 354
352 return results 355 return results
OLDNEW
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698