third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp - Issue 2781713003: Enable module scripts in ScriptLoader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

Issue 2781713003: Enable module scripts in ScriptLoader (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

index 6173cf711bdcf740c591d4b01686e1de045b46ab..b88e096d9e49b8871a63232130f50663e94e9f30 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

@@ -542,6 +542,7 @@ void V8ScriptRunner::ReportExceptionForModule(v8::Isolate* isolate,

v8::False(isolate)); // is_module

ThrowException(isolate, exception, origin);

+ // v8::Exception::TypeError(V8String(isolate, "FOXME Message"))

kouhei (in TOK) 2017/04/24 01:24:03 remove?

hiroshige 2017/04/26 01:09:34 Done.

}

v8::MaybeLocal<v8::Value> V8ScriptRunner::RunCompiledScript(