Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

Issue 2781713003: Enable module scripts in ScriptLoader (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 524 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 v8::Integer::New(isolate, 0), // line_offset 535 v8::Integer::New(isolate, 0), // line_offset
536 v8::Integer::New(isolate, 0), // col_offset 536 v8::Integer::New(isolate, 0), // col_offset
537 v8::Boolean::New(isolate, access_control_status == kSharableCrossOrigin), 537 v8::Boolean::New(isolate, access_control_status == kSharableCrossOrigin),
538 v8::Local<v8::Integer>(), // script id 538 v8::Local<v8::Integer>(), // script id
539 v8::String::Empty(isolate), // source_map_url 539 v8::String::Empty(isolate), // source_map_url
540 v8::Boolean::New(isolate, access_control_status == kOpaqueResource), 540 v8::Boolean::New(isolate, access_control_status == kOpaqueResource),
541 v8::False(isolate), // is_wasm 541 v8::False(isolate), // is_wasm
542 v8::False(isolate)); // is_module 542 v8::False(isolate)); // is_module
543 543
544 ThrowException(isolate, exception, origin); 544 ThrowException(isolate, exception, origin);
545 // v8::Exception::TypeError(V8String(isolate, "FOXME Message"))
kouhei (in TOK) 2017/04/24 01:24:03 remove?
hiroshige 2017/04/26 01:09:34 Done.
545 } 546 }
546 547
547 v8::MaybeLocal<v8::Value> V8ScriptRunner::RunCompiledScript( 548 v8::MaybeLocal<v8::Value> V8ScriptRunner::RunCompiledScript(
548 v8::Isolate* isolate, 549 v8::Isolate* isolate,
549 v8::Local<v8::Script> script, 550 v8::Local<v8::Script> script,
550 ExecutionContext* context) { 551 ExecutionContext* context) {
551 DCHECK(!script.IsEmpty()); 552 DCHECK(!script.IsEmpty());
552 ScopedFrameBlamer frame_blamer( 553 ScopedFrameBlamer frame_blamer(
553 context->IsDocument() ? ToDocument(context)->GetFrame() : nullptr); 554 context->IsDocument() ? ToDocument(context)->GetFrame() : nullptr);
554 TRACE_EVENT1("v8", "v8.run", "fileName", 555 TRACE_EVENT1("v8", "v8.run", "fileName",
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
763 if (!context->GetExtrasBindingObject() 764 if (!context->GetExtrasBindingObject()
764 ->Get(context, V8AtomicString(isolate, name)) 765 ->Get(context, V8AtomicString(isolate, name))
765 .ToLocal(&function_value)) 766 .ToLocal(&function_value))
766 return v8::MaybeLocal<v8::Value>(); 767 return v8::MaybeLocal<v8::Value>();
767 v8::Local<v8::Function> function = function_value.As<v8::Function>(); 768 v8::Local<v8::Function> function = function_value.As<v8::Function>();
768 return V8ScriptRunner::CallInternalFunction(function, v8::Undefined(isolate), 769 return V8ScriptRunner::CallInternalFunction(function, v8::Undefined(isolate),
769 num_args, args, isolate); 770 num_args, args, isolate);
770 } 771 }
771 772
772 } // namespace blink 773 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698