Audit should support Uint8Arrays

Audit should support Uint8Arrays

Allow should() to recognize Uint8Arrays for the actual results.
Previously, this would just return "undefined", and allow the test to
pass, which is incorrect.

BUG=705602
TEST=unit-tests/audit.html

Review-Url: https://codereview.chromium.org/2781643002
Cr-Commit-Position: refs/heads/master@{#460128}
Committed: https://chromium.googlesource.com/chromium/src/+/89a520a13e387fc2331943aeb451b16026e9e00e

[Raymond Toy, 2017-03-27 18:19:24]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-03-27 18:19:24]

PTAL.

I think we should use a more general solution rather than having to enumerate
all the possible typed arrays we want to support.  target instanceof TypedArray
didn't work.

[hongchan, 2017-03-28 16:08:12]

On 2017/03/27 at 18:19:24, rtoy wrote:
> PTAL.
> 
> I think we should use a more general solution rather than having to enumerate
all the possible typed arrays we want to support.  target instanceof TypedArray
didn't work.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje...

"ECMAScript 2015 defines a TypedArray constructor that serves as the
[[Prototype]] of all TypedArray constructors."

This means |target instanceof TypedArray| should work, but I couldn't find
TypedArray.idl in Chromium code. No IDL means no exposed interface. If we want
to be thorough about the typed array, we will have to enumerate everything.

[Raymond Toy, 2017-03-28 16:17:55]

On 2017/03/28 16:08:12, hongchan wrote:
> On 2017/03/27 at 18:19:24, rtoy wrote:
> > PTAL.
> > 
> > I think we should use a more general solution rather than having to
enumerate
> all the possible typed arrays we want to support.  target instanceof
TypedArray
> didn't work.
> 
>
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje...
> 
> "ECMAScript 2015 defines a TypedArray constructor that serves as the
> [[Prototype]] of all TypedArray constructors."
> 
> This means |target instanceof TypedArray| should work, but I couldn't find
> TypedArray.idl in Chromium code. No IDL means no exposed interface. If we want
> to be thorough about the typed array, we will have to enumerate everything.

Adding Uint8Array is probably good enough for now.  I don't think WebAudio
returns anything else besides that and Float32Array's.

[hongchan, 2017-03-28 16:19:31]

lgtm

[Raymond Toy, 2017-03-28 16:22:57]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-03-28 16:24:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 16:44:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490718177494890, "parent_rev":
"0437959c3f974fe8c293118b6ab9507688468cbc", "commit_rev":
"89a520a13e387fc2331943aeb451b16026e9e00e"}

[commit-bot: I haz the power, 2017-03-28 16:45:37]

Description was changed from

==========
Audit should support Uint8Arrays

Allow should() to recognize Uint8Arrays for the actual results.
Previously, this would just return "undefined", and allow the test to
pass, which is incorrect.

BUG=705602
TEST=unit-tests/audit.html
==========

to

==========
Audit should support Uint8Arrays

Allow should() to recognize Uint8Arrays for the actual results.
Previously, this would just return "undefined", and allow the test to
pass, which is incorrect.

BUG=705602
TEST=unit-tests/audit.html

Review-Url: https://codereview.chromium.org/2781643002
Cr-Commit-Position: refs/heads/master@{#460128}
Committed:
https://chromium.googlesource.com/chromium/src/+/89a520a13e387fc2331943aeb451...
==========

[commit-bot: I haz the power, 2017-03-28 16:45:38]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/89a520a13e387fc2331943aeb451...