Allow keyboard shortcuts can be captured by webpage when toolbar is not visible

chrome/test/base/test_browser_window.cc

Index: chrome/test/base/test_browser_window.cc
diff --git a/chrome/test/base/test_browser_window.cc b/chrome/test/base/test_browser_window.cc
index c84cbe9a39e8315d70c5feee12cbb2b9e01eb2cc..2676812a80b99cb47256de94aa54fdba5bfa85dd 100644
--- a/chrome/test/base/test_browser_window.cc
+++ b/chrome/test/base/test_browser_window.cc
@@ -143,6 +143,10 @@ bool TestBrowserWindow::IsToolbarVisible() const {
   return false;
 }
 
+bool TestBrowserWindow::IsToolbarShowing() const {
+  return IsToolbarVisible();

[sky, 2017/04/06 20:38:10]

Is there a reason to have this call IsToolbarVisible? I prefer it return false.

[Hzj_jie, 2017/04/06 20:42:09]

In platform other than Mac OS, the toolbar is showing up when it's available.

[sky, 2017/04/06 21:43:56]

This is a test class though, can't the implementations that need it override to
return whatever they want?

[Hzj_jie, 2017/04/06 21:48:11]

Yes, BrowserWindowCocoa overrides this function and return the visibility of the
toolbar by querying FullscreenToolbarController. Another production
implementation (BrowserView) also returns IsToolbarVisible() in
IsToolbarShowing() to match the cases on other platforms.

[sky, 2017/04/06 23:26:00]

Sorry, I'm confused. Why can't this return false? If you need some test to
override it, then test can do that, right?

+}
+
 ShowTranslateBubbleResult TestBrowserWindow::ShowTranslateBubble(
     content::WebContents* contents,
     translate::TranslateStep step,