Allow keyboard shortcuts can be captured by webpage when toolbar is not visible

chrome/test/base/test_browser_window.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/base/test_browser_window.h"
 
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_list_observer.h"
 #include "content/public/browser/keyboard_event_processing_result.h"
@@ skipping 125 matching lines @@
 }
 
 bool TestBrowserWindow::IsTabStripEditable() const {
   return false;
 }
 
 bool TestBrowserWindow::IsToolbarVisible() const {
   return false;
 }
 
+bool TestBrowserWindow::IsToolbarShowing() const {
+  return IsToolbarVisible();

[sky, 2017/04/06 20:38:10]

Is there a reason to have this call IsToolbarVisible? I prefer it return false.

[Hzj_jie, 2017/04/06 20:42:09]

In platform other than Mac OS, the toolbar is showing up when it's available.

[sky, 2017/04/06 21:43:56]

This is a test class though, can't the implementations that need it override to
return whatever they want?

[Hzj_jie, 2017/04/06 21:48:11]

Yes, BrowserWindowCocoa overrides this function and return the visibility of the
toolbar by querying FullscreenToolbarController. Another production
implementation (BrowserView) also returns IsToolbarVisible() in
IsToolbarShowing() to match the cases on other platforms.

[sky, 2017/04/06 23:26:00]

Sorry, I'm confused. Why can't this return false? If you need some test to
override it, then test can do that, right?

+}
+
 ShowTranslateBubbleResult TestBrowserWindow::ShowTranslateBubble(
     content::WebContents* contents,
     translate::TranslateStep step,
     translate::TranslateErrors::Type error_type,
     bool is_user_gesture) {
   return ShowTranslateBubbleResult::SUCCESS;
 }
 
 autofill::SaveCardBubbleView* TestBrowserWindow::ShowSaveCreditCardBubble(
     content::WebContents* contents,
@@ skipping 52 matching lines @@
 }
 
 TestBrowserWindowOwner::~TestBrowserWindowOwner() {
   BrowserList::RemoveObserver(this);
 }
 
 void TestBrowserWindowOwner::OnBrowserRemoved(Browser* browser) {
   if (browser->window() == window_.get())
     delete this;
 }