Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1995)

Unified Diff: chrome/browser/ui/browser_window.h

Issue 2781633003: Allow keyboard shortcuts can be captured by webpage when toolbar is not visible (Closed)
Patch Set: Resolve review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_window.h
diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h
index 25ded9161b5470971f8520c6f4d309c15f777d7d..add20d4ac5e8ce5c0ca9f6278d055370f3d58b53 100644
--- a/chrome/browser/ui/browser_window.h
+++ b/chrome/browser/ui/browser_window.h
@@ -220,9 +220,17 @@ class BrowserWindow : public ui::BaseWindow {
// Returns whether the tab strip is editable (for extensions).
virtual bool IsTabStripEditable() const = 0;
- // Returns whether the tool bar is visible or not.
+ // Returns whether the toolbar is available or not. It's called "Visible()"
+ // to follow the name convention. But it does not indicate the visibility of
+ // the toolbar, i.e. toolbar may be hidden, and only visible when the mouse
+ // cursor is at a certain place.
+ // TODO(zijiehe): Rename Visible() functions into Available() to match their
+ // original meaning.
virtual bool IsToolbarVisible() const = 0;
+ // Returns whether the toolbar is showing up on the screen.
+ virtual bool IsToolbarShowing() const = 0;
sky 2017/04/06 20:38:10 Will this be renamed to IsToolbarVisible() once yo
Hzj_jie 2017/04/06 20:42:09 I think so. TODO has been added.
+
// Shows the Update Recommended dialog box.
virtual void ShowUpdateChromeDialog() = 0;

Powered by Google App Engine
This is Rietveld 408576698