Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2781623005: [Merge M58] arg: Enable Play Store item in App Launcher for managed case. (Closed)

Created:
3 years, 8 months ago by khmel
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge M58] arg: Enable Play Store item in App Launcher for managed case. This fixes issue when Play Store item is not available for ARC managed and enabled case. NOTRY=true NOPRESUBMIT=true TBR=xiyuan@chromium.org BUG=700601 BUG=b/36043525 TEST=Extended unit_tests TEST=Manually on Caroline, normal case (@gmail.com), managed enabled (@google.com) and managed disabled (@chromium.org). Review-Url: https://codereview.chromium.org/2738983003 Cr-Commit-Position: refs/heads/master@{#455894} (cherry picked from commit 8d651457cff4086e56e9861bc24ae1f127b590d6) Review-Url: https://codereview.chromium.org/2781623005 Cr-Commit-Position: refs/branch-heads/3029@{#453} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/b8357dd7fdc55e484b98b4f9e792e439924b81eb

Patch Set 1 #

Patch Set 2 : fix merge conflicts / unit tests passed / manually tested on device #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -69 lines) Patch
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 4 chunks +19 lines, -9 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 1 35 chunks +124 lines, -53 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_default_app_list.h View 3 chunks +15 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_default_app_list.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781623005/20001
3 years, 8 months ago (2017-03-28 17:41:05 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 17:44:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b8357dd7fdc55e484b98b4f9e792...

Powered by Google App Engine
This is Rietveld 408576698