PDF Viewer pinch zoom: Update state for zoom in following a zoom out.

PDF Viewer pinch zoom: Update state for zoom in following a zoom out.

If we pinch zoom out, we need to update the state we use to calculate
the translation of the PDF content if we proceed to zoom in during
the same gesture.

BUG=705586
Review-Url: https://codereview.chromium.org/2781613002
Cr-Commit-Position: refs/heads/master@{#460758}
Committed: https://chromium.googlesource.com/chromium/src/+/60f6a1eeebb81e29c0a6b351ed2e3c432787fbc4

[Kevin McNee, 2017-03-27 17:43:38]

The CQ bit was checked by mcnee@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 17:44:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kevin McNee, 2017-03-27 17:45:53]

Description was changed from

==========
PDF Viewer pinch zoom: Update state for zoom in following a zoom out.

If we pinch zoom out, we need to update the state we use to calculate
the translation of the PDF content if we proceed to zoom in during
the same gesture.

BUG=705586
==========

to

==========
PDF Viewer pinch zoom: Update state for zoom in following a zoom out.

If we pinch zoom out, we need to update the state we use to calculate
the translation of the PDF content if we proceed to zoom in during
the same gesture.

BUG=705586
==========

[Kevin McNee, 2017-03-27 17:45:54]

mcnee@chromium.org changed reviewers:
+ bokan@chromium.org, thestig@chromium.org

[Kevin McNee, 2017-03-27 17:48:06]

Hello, thestig. I have another fix for PDF pinch zooming. Could you take a look?
Again, adding bokan for the pinch zooming logic.

[commit-bot: I haz the power, 2017-03-27 18:36:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 18:36:54]

Dry run: This issue passed the CQ dry run.

[bokan, 2017-03-28 14:26:26]

lgtm % comment

https://codereview.chromium.org/2781613002/diff/1/pdf/out_of_process_instance.cc
File pdf/out_of_process_instance.cc (right):

https://codereview.chromium.org/2781613002/diff/1/pdf/out_of_process_instance...
pdf/out_of_process_instance.cc:504: starting_scroll_offset_ = scroll_offset;
These two variables are the offset/zoom since last raster, right? Please update
the comment on starting_scroll_offset_ to make that more clear (and add a
similar comment on initial_zoom_ratio_) if that's right.

[Lei Zhang, 2017-03-28 20:46:46]

lgtm

[Kevin McNee, 2017-03-28 22:55:26]

https://codereview.chromium.org/2781613002/diff/1/pdf/out_of_process_instance.cc
File pdf/out_of_process_instance.cc (right):

https://codereview.chromium.org/2781613002/diff/1/pdf/out_of_process_instance...
pdf/out_of_process_instance.cc:504: starting_scroll_offset_ = scroll_offset;
On 2017/03/28 14:26:26, bokan wrote:
> These two variables are the offset/zoom since last raster, right? Please
update
> the comment on starting_scroll_offset_ to make that more clear (and add a
> similar comment on initial_zoom_ratio_) if that's right.

So it turns out that |initial_zoom_ratio_| is redundant since |zoom_| gives us
all the information we need, so I've gone ahead and removed it entirely. Also,
I've renamed |starting_scroll_offset_| to |scroll_offset_at_last_raster_| to
better describe its purpose.

Still LGTM?

[Kevin McNee, 2017-03-28 22:55:51]

The CQ bit was checked by mcnee@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 22:56:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 23:04:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 23:04:21]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[bokan, 2017-03-29 11:21:56]

thanks, lgtm

[Kevin McNee, 2017-03-29 14:06:29]

The CQ bit was checked by mcnee@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 14:06:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 15:38:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 15:38:16]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Kevin McNee, 2017-03-29 15:48:12]

The CQ bit was checked by mcnee@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 15:49:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 17:25:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 17:25:03]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Kevin McNee, 2017-03-29 22:12:00]

The CQ bit was checked by mcnee@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 22:12:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 22:54:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 22:54:25]

Dry run: This issue passed the CQ dry run.

[Kevin McNee, 2017-03-30 14:24:55]

The CQ bit was checked by mcnee@chromium.org

[Kevin McNee, 2017-03-30 14:24:56]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2781613002/#ps20001
(title: "Remove redundant code and clarify variable.")

[commit-bot: I haz the power, 2017-03-30 14:25:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 15:15:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490883895603330,
"parent_rev": "6f3586e7de633c64aa318bdcf281f2d9edc4d93f", "commit_rev":
"60f6a1eeebb81e29c0a6b351ed2e3c432787fbc4"}

[commit-bot: I haz the power, 2017-03-30 15:16:17]

Description was changed from

==========
PDF Viewer pinch zoom: Update state for zoom in following a zoom out.

If we pinch zoom out, we need to update the state we use to calculate
the translation of the PDF content if we proceed to zoom in during
the same gesture.

BUG=705586
==========

to

==========
PDF Viewer pinch zoom: Update state for zoom in following a zoom out.

If we pinch zoom out, we need to update the state we use to calculate
the translation of the PDF content if we proceed to zoom in during
the same gesture.

BUG=705586

Review-Url: https://codereview.chromium.org/2781613002
Cr-Commit-Position: refs/heads/master@{#460758}
Committed:
https://chromium.googlesource.com/chromium/src/+/60f6a1eeebb81e29c0a6b351ed2e...
==========

[commit-bot: I haz the power, 2017-03-30 15:16:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/60f6a1eeebb81e29c0a6b351ed2e...