[Content suggestions] Add a feature to fetch favicons from a new server

[Content suggestions] Add a feature to fetch favicons from a new server

Together with CL 2781583002, this CL prepares fetching publishers
favicons in c++, using the new API function of LargeIconService.

In follow-up CLs, I will:
 - implement the actual functionality in ContentSuggestionsService,
 - switch in SnippetArticleViewHolder between the old and the new code
   path, based on the feature introduced in this CL.

BUG=705572
Review-Url: https://codereview.chromium.org/2781603002
Cr-Commit-Position: refs/heads/master@{#460678}
Committed: https://chromium.googlesource.com/chromium/src/+/18514e66cea2de4f902f300d6b136f4bb9b18b6b

[jkrcal, 2017-03-27 17:29:03]

jkrcal@chromium.org changed reviewers:
+ bauerb@chromium.org

[jkrcal, 2017-03-27 17:29:04]

Bernhard, could you PTAL?

[Bernhard Bauer, 2017-03-28 11:25:19]

LGTM with a naming nit:

https://codereview.chromium.org/2781603002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
(right):

https://codereview.chromium.org/2781603002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java:148:
"ContentSuggestionsFaviconsFromNewServer";
Can we make the name and value of this feature consistent? I don't care which
way.

[jkrcal, 2017-03-28 12:05:08]

Thanks!

https://codereview.chromium.org/2781603002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
(right):

https://codereview.chromium.org/2781603002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java:148:
"ContentSuggestionsFaviconsFromNewServer";
On 2017/03/28 11:25:18, Bernhard Bauer wrote:
> Can we make the name and value of this feature consistent? I don't care which
> way.

Done.

[jkrcal, 2017-03-28 12:05:17]

The CQ bit was checked by jkrcal@chromium.org

[jkrcal, 2017-03-28 12:05:17]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2781603002/#ps20001
(title: "Bernhard's comment")

[commit-bot: I haz the power, 2017-03-28 12:05:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 12:55:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 12:55:11]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[jkrcal, 2017-03-29 08:04:11]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 08:04:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 08:50:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 08:51:00]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jkrcal, 2017-03-29 09:48:48]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 09:49:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkrcal, 2017-03-29 09:49:52]

jkrcal@chromium.org changed reviewers:
+ isherman@chromium.org

[jkrcal, 2017-03-29 09:49:53]

Ilya, could you PTAL at histograms.xml?

[commit-bot: I haz the power, 2017-03-29 11:02:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 11:02:32]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ilya Sherman, 2017-03-29 22:06:23]

histograms.xml lgtm

[jkrcal, 2017-03-30 06:07:28]

The CQ bit was checked by jkrcal@chromium.org

[jkrcal, 2017-03-30 06:07:30]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2781603002/#ps60001
(title: "Add histogram.xml LoginCustomFlags entries")

[commit-bot: I haz the power, 2017-03-30 06:07:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 06:12:36]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490854048790910,
"parent_rev": "49e09c1721596fe0925bfd290750fd6c707b09cc", "commit_rev":
"18514e66cea2de4f902f300d6b136f4bb9b18b6b"}

[commit-bot: I haz the power, 2017-03-30 06:14:32]

Description was changed from

==========
[Content suggestions] Add a feature to fetch favicons from a new server

Together with CL 2781583002, this CL prepares fetching publishers
favicons in c++, using the new API function of LargeIconService.

In follow-up CLs, I will:
 - implement the actual functionality in ContentSuggestionsService,
 - switch in SnippetArticleViewHolder between the old and the new code
   path, based on the feature introduced in this CL.

BUG=705572
==========

to

==========
[Content suggestions] Add a feature to fetch favicons from a new server

Together with CL 2781583002, this CL prepares fetching publishers
favicons in c++, using the new API function of LargeIconService.

In follow-up CLs, I will:
 - implement the actual functionality in ContentSuggestionsService,
 - switch in SnippetArticleViewHolder between the old and the new code
   path, based on the feature introduced in this CL.

BUG=705572

Review-Url: https://codereview.chromium.org/2781603002
Cr-Commit-Position: refs/heads/master@{#460678}
Committed:
https://chromium.googlesource.com/chromium/src/+/18514e66cea2de4f902f300d6b13...
==========

[commit-bot: I haz the power, 2017-03-30 06:14:37]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/18514e66cea2de4f902f300d6b13...