Integrate Desktop iOS promotion with bookmarks.

chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h

Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
index 56b255d4d208ce974e990a51085e4adad9f6c6cd..5f87cd08050ca96f4fcb16e98c3c0bcf6545bd33 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
@@ -20,6 +20,8 @@
 
 class Profile;
 
+class DesktopIOSPromotionBubbleView;
+
 namespace bookmarks {
 class BookmarkBubbleObserver;
 }
@@ -60,6 +62,8 @@ class BookmarkBubbleView : public LocationBarBubbleDelegateView,
   // views::WidgetDelegate:
   void WindowClosing() override;
   bool AcceleratorPressed(const ui::Accelerator& accelerator) override;
+  gfx::ImageSkia GetWindowIcon() override;
+  bool ShouldShowWindowIcon() const override;
 
  protected:
   // views::BubbleDialogDelegateView method.
@@ -103,6 +107,9 @@ class BookmarkBubbleView : public LocationBarBubbleDelegateView,
   // Shows the BookmarkEditor.
   void ShowEditor();
 
+  // Shows the iOS promotion.
+  void ShowIOSPromotion();
+
   // Sets the title and parent of the node.
   void ApplyEdits();
 
@@ -142,12 +149,18 @@ class BookmarkBubbleView : public LocationBarBubbleDelegateView,
   // the current parent.
   views::Combobox* parent_combobox_;
 
+  // iOS promotion view.
+  DesktopIOSPromotionBubbleView* ios_promo_view_;

[sky, 2017/03/27 20:03:55]

This is never initialized. I recommend initializing right here, same with
ios_promotion_views_. Less error prone.

[mrefaat, 2017/03/29 19:50:18]

i added initialization on the constructor for consistency. 

+
   // When the destructor is invoked should the bookmark be removed?
   bool remove_bookmark_;
 
   // When the destructor is invoked should edits be applied?
   bool apply_edits_;
 
+  // Was the Windows to iOS promotion shown to the user.
+  bool ios_promotion_viewed_;

[sky, 2017/03/27 20:03:55]

I think you want is_showing_ios_promotion_?

[mrefaat, 2017/03/29 19:50:18]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(BookmarkBubbleView);
 };