Integrate Desktop iOS promotion with bookmarks.

chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BUBBLE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BUBBLE_VIEW_H_
 
 #include <memory>
 
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/strings/string16.h"
 #include "chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h"
 #include "chrome/browser/ui/sync/bubble_sync_promo_delegate.h"
 #include "chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/controls/combobox/combobox_listener.h"
 #include "url/gurl.h"
 
 class Profile;
 
+class DesktopIOSPromotionBubbleView;
+
 namespace bookmarks {
 class BookmarkBubbleObserver;
 }
 
 namespace views {
 class LabelButton;
 class Textfield;
 }
 
 // BookmarkBubbleView is a view intended to be used as the content of an
@@ skipping 20 matching lines @@
 
   static void Hide();
 
   static BookmarkBubbleView* bookmark_bubble() { return bookmark_bubble_; }
 
   ~BookmarkBubbleView() override;
 
   // views::WidgetDelegate:
   void WindowClosing() override;
   bool AcceleratorPressed(const ui::Accelerator& accelerator) override;
+  gfx::ImageSkia GetWindowIcon() override;
+  bool ShouldShowWindowIcon() const override;
 
  protected:
   // views::BubbleDialogDelegateView method.
   void Init() override;
   base::string16 GetWindowTitle() const override;
 
  private:
   friend class BookmarkBubbleViewTest;
   FRIEND_TEST_ALL_PREFIXES(BookmarkBubbleViewTest, SyncPromoSignedIn);
   FRIEND_TEST_ALL_PREFIXES(BookmarkBubbleViewTest, SyncPromoNotSignedIn);
@@ skipping 23 matching lines @@
 
   // Overridden from views::ComboboxListener:
   void OnPerformAction(views::Combobox* combobox) override;
 
   // Handle the message when the user presses a button.
   void HandleButtonPressed(views::Button* sender);
 
   // Shows the BookmarkEditor.
   void ShowEditor();
 
+  // Shows the iOS promotion.
+  void ShowIOSPromotion();
+
   // Sets the title and parent of the node.
   void ApplyEdits();
 
   // The bookmark bubble, if we're showing one.
   static BookmarkBubbleView* bookmark_bubble_;
 
   // Our observer, to notify when the bubble shows or hides.
   bookmarks::BookmarkBubbleObserver* observer_;
 
   // Delegate, to handle clicks on the sign in link.
@@ skipping 19 matching lines @@
   // Button to close the window.
   views::LabelButton* close_button_;
 
   // Textfield showing the title of the bookmark.
   views::Textfield* title_tf_;
 
   // Combobox showing a handful of folders the user can choose from, including
   // the current parent.
   views::Combobox* parent_combobox_;
 
+  // iOS promotion view.
+  DesktopIOSPromotionBubbleView* ios_promo_view_;

[sky, 2017/03/27 20:03:55]

This is never initialized. I recommend initializing right here, same with
ios_promotion_views_. Less error prone.

[mrefaat, 2017/03/29 19:50:18]

i added initialization on the constructor for consistency. 

+
   // When the destructor is invoked should the bookmark be removed?
   bool remove_bookmark_;
 
   // When the destructor is invoked should edits be applied?
   bool apply_edits_;
 
+  // Was the Windows to iOS promotion shown to the user.
+  bool ios_promotion_viewed_;

[sky, 2017/03/27 20:03:55]

I think you want is_showing_ios_promotion_?

[mrefaat, 2017/03/29 19:50:18]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(BookmarkBubbleView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BUBBLE_VIEW_H_