Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8602)

Unified Diff: chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc

Issue 2781553003: Integrate Desktop iOS promotion with bookmarks. (Closed)
Patch Set: address comments 3 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bubble_view_browsertest.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc
diff --git a/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc b/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc
index 39b9a08b5ff55526cdb2ec8cd86762b442e7afe9..99b46c85d11ce2a48cf702e29058a48ecc52b20b 100644
--- a/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc
+++ b/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc
@@ -16,19 +16,6 @@
#include "ui/views/controls/button/md_text_button.h"
#include "ui/views/layout/grid_layout.h"
-namespace {
-
-int GetDesiredBubbleMaxWidth(
- desktop_ios_promotion::PromotionEntryPoint entry_point) {
- if (entry_point ==
- desktop_ios_promotion::PromotionEntryPoint::SAVE_PASSWORD_BUBBLE) {
- return ManagePasswordsBubbleView::kDesiredBubbleWidth;
- }
- return 0;
-}
-
-} // namespace
-
DesktopIOSPromotionBubbleView::DesktopIOSPromotionBubbleView(
Profile* profile,
desktop_ios_promotion::PromotionEntryPoint entry_point)
@@ -38,8 +25,7 @@ DesktopIOSPromotionBubbleView::DesktopIOSPromotionBubbleView(
base::MakeUnique<DesktopIOSPromotionController>(profile,
this,
entry_point)) {
- int bubble_width =
- ::GetDesiredBubbleMaxWidth(promotion_controller_->entry_point());
+ int bubble_width = ManagePasswordsBubbleView::kDesiredBubbleWidth;
views::GridLayout* layout = new views::GridLayout(this);
layout->set_minimum_size(gfx::Size(bubble_width, 0));
SetLayoutManager(layout);
« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bubble_view_browsertest.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698