Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view_browsertest.cc

Issue 2781553003: Integrate Desktop iOS promotion with bookmarks. (Closed)
Patch Set: address comments 3 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view_browsertest.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_browsertest.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9b2b1f764a44f97a831a3aafc75cff23c8009099
--- /dev/null
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_browsertest.cc
@@ -0,0 +1,98 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/bookmarks/bookmark_model_factory.h"
+#include "chrome/browser/signin/fake_signin_manager_builder.h"
+#include "chrome/browser/signin/signin_manager_factory.h"
+#include "chrome/browser/ui/test/test_browser_dialog.h"
+#include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h"
+#include "chrome/browser/ui/views/frame/browser_view.h"
+#include "chrome/browser/ui/views/location_bar/star_view.h"
+#include "chrome/browser/ui/views/toolbar/toolbar_view.h"
+#include "chrome/test/base/browser_with_test_window_test.h"
+#include "components/bookmarks/browser/bookmark_utils.h"
+#include "components/bookmarks/test/bookmark_test_helpers.h"
+
+namespace {
+
+const char kTestBookmarkURL[] = "http://www.google.com";
+const char kTestGaiaID[] = "test";
+const char kTestUserEmail[] = "testuser@gtest.com";
+
+} // namespace
+
+class BookmarkBubbleViewBrowserTest : public DialogBrowserTest {
+ public:
+ BookmarkBubbleViewBrowserTest() {}
+
+ void SetUpOnMainThread() override {
+ TestingProfile::Builder builder;
+ builder.AddTestingFactory(SigninManagerFactory::GetInstance(),
+ BuildFakeSigninManagerBase);
+ profile_ = builder.Build();
+ profile_->CreateBookmarkModel(true);
+ bookmarks::BookmarkModel* bookmark_model =
+ BookmarkModelFactory::GetForBrowserContext(profile_.get());
+ bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model);
+ bookmarks::AddIfNotBookmarked(bookmark_model, GURL(kTestBookmarkURL),
+ base::string16());
+ }
+
+ void TearDownOnMainThread() override { profile_.reset(); }
+
+ void ShowDialog(const std::string& name) override {
+ BrowserView* browser_view =
+ BrowserView::GetBrowserViewForBrowser(browser());
+
+ if ("bookmark_details" == name) {
+#if !defined(OS_CHROMEOS)
+ SigninManagerFactory::GetForProfile(profile_.get())
+ ->SignOut(signin_metrics::SIGNOUT_TEST,
+ signin_metrics::SignoutDelete::IGNORE_METRIC);
+#endif
+ BookmarkBubbleView::ShowBubble(
+ browser_view->toolbar()->location_bar()->star_view(), gfx::Rect(),
+ nullptr, nullptr, nullptr, profile_.get(), GURL(kTestBookmarkURL),
+ true);
+ } else if ("bookmark_details_signed_in" == name) {
+ SigninManagerFactory::GetForProfile(profile_.get())
+ ->SetAuthenticatedAccountInfo(kTestGaiaID, kTestUserEmail);
+ BookmarkBubbleView::ShowBubble(
+ browser_view->toolbar()->location_bar()->star_view(), gfx::Rect(),
+ nullptr, nullptr, nullptr, profile_.get(), GURL(kTestBookmarkURL),
+ true);
+#if defined(OS_WIN)
+ } else if ("ios_promotion" == name) {
+ SigninManagerFactory::GetForProfile(profile_.get())
+ ->SetAuthenticatedAccountInfo(kTestGaiaID, kTestUserEmail);
+ BookmarkBubbleView::ShowBubble(
+ browser_view->toolbar()->location_bar()->star_view(), gfx::Rect(),
+ nullptr, nullptr, nullptr, profile_.get(), GURL(kTestBookmarkURL),
+ true);
+ BookmarkBubbleView::bookmark_bubble()->ShowIOSPromotion();
+#endif
+ }
+ }
+
+ private:
+ std::unique_ptr<TestingProfile> profile_;
+ DISALLOW_COPY_AND_ASSIGN(BookmarkBubbleViewBrowserTest);
+};
+
+IN_PROC_BROWSER_TEST_F(BookmarkBubbleViewBrowserTest,
+ InvokeDialog_bookmark_details) {
+ RunDialog();
+}
+
+IN_PROC_BROWSER_TEST_F(BookmarkBubbleViewBrowserTest,
+ InvokeDialog_bookmark_details_signed_in) {
+ RunDialog();
+}
+
+#if defined(OS_WIN)
+IN_PROC_BROWSER_TEST_F(BookmarkBubbleViewBrowserTest,
+ InvokeDialog_ios_promotion) {
+ RunDialog();
+}
+#endif

Powered by Google App Engine
This is Rietveld 408576698