Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2781553002: gpu: Introduce separate mojo api for failed initialization. (Closed)

Created:
3 years, 9 months ago by sadrul
Modified:
3 years, 9 months ago
Reviewers:
Tom Sepez, piman
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Introduce separate mojo api for failed initialization. Introduce a separate DidFailInitialization() api to notify the host when gpu initialization fails. Update the DidInitialize() api to take in the GpuFeatureInfo as well as the GPUInfo. BUG=643746 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2781553002 Cr-Commit-Position: refs/heads/master@{#459909} Committed: https://chromium.googlesource.com/chromium/src/+/a235d7cf5d45775a50e0b811a7dd3a411494cd64

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -16 lines) Patch
M content/browser/gpu/gpu_process_host.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +7 lines, -1 line 0 comments Download
M content/gpu/gpu_child_thread.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M gpu/ipc/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A gpu/ipc/common/gpu_feature_info.mojom View 1 chunk +23 lines, -0 lines 0 comments Download
A gpu/ipc/common/gpu_feature_info.typemap View 1 chunk +17 lines, -0 lines 0 comments Download
A gpu/ipc/common/gpu_feature_info_struct_traits.h View 1 1 chunk +76 lines, -0 lines 0 comments Download
M gpu/ipc/common/struct_traits_unittest.cc View 1 2 chunks +21 lines, -0 lines 0 comments Download
M gpu/ipc/common/typemaps.gni View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/gpu/gpu_main.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/ui/gpu/gpu_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/gpu/gpu_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M services/ui/gpu/interfaces/gpu_host.mojom View 2 chunks +5 lines, -1 line 0 comments Download
M services/ui/ws/gpu_host.h View 1 chunk +3 lines, -1 line 0 comments Download
M services/ui/ws/gpu_host.cc View 1 chunk +4 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
sadrul
tsepez@: Please review the mojom and the struct trait changes. piman@: Please review the mojom ...
3 years, 9 months ago (2017-03-27 16:25:48 UTC) #8
piman
lgtm
3 years, 9 months ago (2017-03-27 17:59:29 UTC) #9
Tom Sepez
lgtm
3 years, 9 months ago (2017-03-27 18:45:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781553002/20001
3 years, 9 months ago (2017-03-27 20:19:30 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 22:34:14 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a235d7cf5d45775a50e0b811a7dd...

Powered by Google App Engine
This is Rietveld 408576698