Issue 2781493002: Throw AbstractClassInstantiationError on abstract classes.

Issue 2781493002: Throw AbstractClassInstantiationError on abstract classes. (Closed)

Created:
3 years, 9 months ago by ahe

Modified:
3 years, 8 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Throw AbstractClassInstantiationError on abstract classes. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/a6ba01e8aa56559ab1a27c2e2e8177a0c1019dfc

Patch Set 2 : Ensure arguments are evaluated before abstract class error. #

Patch Set 3 : Add bug number. #

Patch Set 4 : Address comments. #

Patch Set 5 : Update co19 status. #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -12 lines)			Patch
M	pkg/front_end/lib/src/fasta/kernel/body_builder.dart	View	1 2 3 4	4 chunks	+32 lines, -3 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/loader.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/target_implementation.dart	View	1 2 3	2 chunks	+13 lines, -0 lines	0 comments	Download
M	tests/co19/co19-kernel.status	View	1 2 3 4	3 chunks	+0 lines, -6 lines	0 comments	Download
A	tests/language/abstract_beats_arguments2_test.dart	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/language/language_kernel.status	View	1 2 3 4	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

karlklose

LGTM https://codereview.chromium.org/2781493002/diff/1/pkg/front_end/lib/src/fasta/target_implementation.dart File pkg/front_end/lib/src/fasta/target_implementation.dart (right): https://codereview.chromium.org/2781493002/diff/1/pkg/front_end/lib/src/fasta/target_implementation.dart#newcode60 pkg/front_end/lib/src/fasta/target_implementation.dart:60: return cachedAbstractClassInstantiationError; Use {}

3 years, 9 months ago (2017-03-28 05:19:34 UTC) #4

ahe

Thank you, Karl! https://codereview.chromium.org/2781493002/diff/1/pkg/front_end/lib/src/fasta/target_implementation.dart File pkg/front_end/lib/src/fasta/target_implementation.dart (right): https://codereview.chromium.org/2781493002/diff/1/pkg/front_end/lib/src/fasta/target_implementation.dart#newcode60 pkg/front_end/lib/src/fasta/target_implementation.dart:60: return cachedAbstractClassInstantiationError; On 2017/03/28 05:19:34, karlklose ...

3 years, 8 months ago (2017-03-29 07:41:02 UTC) #5

ahe

3 years, 8 months ago (2017-03-29 08:38:22 UTC) #7

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as
a6ba01e8aa56559ab1a27c2e2e8177a0c1019dfc (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages